Fix syntax of expectException() calls

[schmengler]

Description

RegEx search and replace from ( *)\$this->expectException\(([^\n,]+), ([^)\n]+)\); to $1\$this->expectException($2);\n$1\$this->expectExceptionMessage($3);

Fixed Issues (if relevant)

1. 92 usages of expectException() with ignored $message parameter #11059: 92 usages of expectException() with ignored $message parameter

Manual testing scenarios

1. Change an exception message that should be covered by a test

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[vrann]

@schmengler there were couple problems in the tests:

• Magento\Test\Bootstrap\SettingsTest::testGetAsConfigFileException with data set "non-existing setting" ('non_existing', Magento\Framework\Phrase Object (...)) PHPUnit\Framework\Exception: Argument #1 (No Value) of PHPUnit\Framework\TestCase::expectExceptionMessage() must be a string
• Magento\Test\Bootstrap\SettingsTest::testGetAsConfigFileException with data set "non-existing file" ('item_label', Magento\Framework\Phrase Object (...)) PHPUnit\Framework\Exception: Argument #1 (No Value) of PHPUnit\Framework\TestCase::expectExceptionMessage() must be a string
• Magento\Catalog\Api\ProductCustomOptionRepositoryTest::testUpdateNegative with data set "missed_product_sku" (array('title', 'field', 1, 1, 10.0, 'fixed', 'sku1', 10), 'ProductSku should be specified') Failed asserting that exception message '{"message":"Requested product doesn't exist"}' contains 'ProductSku should be specified'.

is that something you can fix? If yes, can you re-create PR with the latest 2.2-develop?

[schmengler]

recreated the PR, will see that I can fix the errors

[vrann]

@schmengler thank you!