Skip to content

Canceled invoice can be canceled again #9968

Closed
@redelschaap

Description

@redelschaap

A canceled invoice can be canceled again. I think \Magento\Sales\Model\Order\Invoice::cancel should check whether the invoice can be canceled before executing all cancel operations.

Preconditions

  1. Tested on Magento 2.1.5

Steps to reproduce

  1. Load a canceled invoice programmatically
  2. Call $invoice->cancel()

Expected result

  1. Throw an exception saying the invoice has already been canceled.

Actual result

  1. The invoice gets canceled twice, so order amounts are also being adjusted twice.

Metadata

Metadata

Assignees

Labels

Component: SalesFixed in 2.2.xThe issue has been fixed in 2.2 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.1.xThe issue has been reproduced on latest 2.1 releaseReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releasebug report

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions