Newsletter name and email wrong way around so name cannot be set

[cylix99]

https://github.com/magento/magento2/blob/develop/app/code/Magento/Newsletter/Model/Queue.php#L239

getNewsletterSenderEmail and getNewsletterSenderName are the wrong way around

Preconditions

Steps to reproduce

1. Send a newsletter setting email to email address and name to short name and email failed

Expected result

1. to fix line 239 should read
   ['name' => $this->getNewsletterSenderName(), 'email' => $this->getNewsletterSenderEmail()]

Actual result

1. [Screenshot, logs]

[veloraven]

@cylix99 thank you for your report.
Please identify which version of Magento you are running.
Please provide more detailed steps.
Please also provide expected and actual results in format what exactly you expect to get and get actually.

[mark-aculus]

I can confirm that I am having the exact same issue as @cylix99.

I am running Magento 2.1.0

I am using one module to send emails out through SMTP. It is possible that it has aggravated the situation, otherwise, I think newsletters wouldn't really work for anyone. This is the custom module I am using:

https://www.magentocommerce.com/magento-connect/smtp-pro-email-free-custom-smtp-email.html

To cause the issue, I simply create a newsletter with sender name: "Sales" and sender email: "sales@example.com". Next I queue up the newsletter and wait. Eventually the UI will say the newsletter was successfully sent, but I won't see it in my inbox.

Like @cylix99 I saw the same issue in the code that he mentioned. My work-around has been to just make sure sender name and sender email are both email addresses. When I do this the email sends through without a problem.

I think cylix99 has the right fix. It looks like a typo in the code to me.

[veloraven]

@cylix99 , @mark-aculus this issue was fixed in develop branch by commit 9b7dd77 from PR #6354

[korostii]

Hi @veloraven, I see that you've added a needs update label.
Would you please care to explain, what exact kind of information do you need from community in order to proceed with backporting an existing fix to the 2.1.x branch?