Magento_Review: disable brakes product page in admin

[friizu]

Disabled reviews under admin -> stores -> configuration-> advanced ->advanced

Expected to disable reviews from store

Bug: product page in admin brakes
Message: Attention, Something went wrong.

Console:
Failed to load resource: the server responded with a status of 500 (Internal Server Error)
.../admin/mui/index/render/?namespace=review_listing&isAjax=true

Product reviews tab is still there and can't load. Product cant be edited.

This bug is new in 2.1.1 was ok earlier versions

[veloraven]

@friizu please try to clear browser's cache and let us know if it will help.

[friizu]

@veloraven - No it won't help (cleared browser cache, cleared page cache etc). Also all is ok if i enable it again. Seems like disable wont remove review tab on admin product page and cause module is disabled it can't load content to this tab. I suppose this tab should not be on admin product page at all after module itself is disabled.

[hostep]

@friizu: this bug also existed in Magento 2.1.0 and was reported 4 or 5 times before. So please try to search for existing issues before creating a new one :)
Linking to the issue where all the other issues also get linked into: #5323

[friizu]

Hmm I did not had this issue in 2.1.0 I got this after update from 2.1.0 to 2.1.1

[southerncomputer]

Magento 2.1.1 EE does not disable di or other /etc/*.xml changes when a module is disabled! this is insane that you have to physically remove the module from the source tree and setup_database version tracker table to fully disable a module!

Try it! disable a module with events.xml or di.xml and watch it get compiled in with setup:di:compile / setup:static-content:deploy and wreak havoc on the rest of the magento installation as weird bugs get introduced!

[oshmyheliuk]

Hi @friizu
Did you disable whole Review module via "Web Setup Wizard" or just disable module output in Configuration -> Advanced -> Advanced ?

[friizu]

I just disabled module output in admin configuration -> advanced -> advanced, cause i may need it later, i just wanted to hide that for first release of page.

[oshmyheliuk]

We already have internal ticket MAGETWO-56794 for the same issue