-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Wrong price format when it is loaded by JS file #6362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi! Why do you think it is wrong? According to standards separators in es_XX locale are opposite to en_XX. See example https://en.wikipedia.org/wiki/Decimal_mark#Examples_of_use |
@sevos1984 I'm from Mexico, we use the decimal dot. You can see that in the first row from that wikipedia table. I'd like to highlight that the issue is only present when price is loaded by JS, anywhere else in the store and backend, the price format is ok. |
Thanks for clarification, internal ticket created MAGETWO-57833 |
@sevos1984 Is there a temporary solution for this? If so, could you share it here? I'm sorry to ask here but I haven't found a solution anywhere else. |
I don't have any but use another locale. |
Hi, for local usage wikipedia is correct, but not for international usage: Use '.' (Unicode 'FULL STOP' (U+002E)) rather than ',' to indicate a decimal point. Avoid using these symbols as a readability separator. In this case how can I change price just for product detail page: 1,599.00 € ? |
any update on this issue.? i can able to change in product view page . but still i am not able to change in product details page. ?can any tell me where to change .? |
@fazilpm I think there is not a solution yet. However, you can solve it by using the United States locale and name your translation file en_US.csv |
@lgarridoj can you please tell me where is the location of the file en_US.csv |
@fazilpm you have to create it and configure Magento to use that locale. You can find all information about translation in the official magento documentation website |
Although this is not a correct solution you can override vendor/magento/framework/Locale/Format.php to fix the currency format to your choosing, after $groupSymbol definition (around line 124), localeCode should be the target locale.
|
@lgarridoj, thank you for your report. |
[Sidecar] Fixes for 2.4 (pr7)
Preconditions
Steps to reproduce
Expected result
Actual result
The text was updated successfully, but these errors were encountered: