Skip to content

Checkbox IDs for Terms and Conditions should be unique in Checkout #6207

Closed
@bka

Description

@bka

Magento_CheckoutAgreements places checkboxes into checkout to accept the respective terms and conditions. However, the html tag for the checkbox appears for each payment method with the same html id. It is bad practice to have the same html id multiple times and also introduces problems with css customization for these boxes which relies on unique ids.

Preconditions

  1. Install Magento 2.1

Steps to reproduce

  1. Create a Term and Condition under Stores -> Terms and Conditions
  2. Activate Terms and Conditions under Stores -> SALES -> Checkout -> Enable Terms and Conditions
  3. Enable a second payment method e.g. Bank Transfer Payment
  4. Got through checkout process to Review & Payment
  5. Inspect HTML of checkbox tag for configured term

Expected result

  1. Each input field of type checkbox should have a unique html id

Actual result

  1. HTML contains 2 input fields of type checkbox with same id agreement_1

auswahl_006

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions