Minify JavaScript files / .min added to paypal file

[exreplay]

When "Minify JavaScript Files" is turned on, Magento does add .min to the external paypal script. You can enable merge or bundling, both don't affect the file or in general external files.

Preconditions

1. Magento 2.1.0
2. PHP-FPM 7.0.8
3. 10.1.16-MariaDB-1~jessie

Steps to reproduce

1. Login to Backend
2. Shops -> Configuration ->Advanced -> Developer -> JavaScript Settings
3. Put "Minify JavaScript Files" to "Yes"
4. Save Config

Expected result

1. "https://www.paypalobjects.com/api/checkout.js" is included

Actual result

1. "https://www.paypalobjects.com/api/checkout.min.js" is included

[kandy]

Thanks for reporting, but https://www.paypalobjects.com/api/checkout.min.js return 404. Looks like expected result are wrong so I am closing this issue, as fixed. Feel free to reopen issue if we missed anything.

[hostep]

@kandy: the expected result is without the .min in the filename, I think you switched expected with actual results?

Maybe best to reopen and confirm if this is an actual problem (it does sounds like a possible bug).

[kandy]

oh, sorry, my miss

[exreplay]

No problem.
The main problem is, when PayPal is integrated and you turn on the minification, sites break because of that.

[Sam-PUMP]

Having the same issue.

[mengento]

Temporary solution
Change line 243 of Magento/Framework/RequireJs/Config.php

Url = url.replace (/ (\. Min)? \. Js $ /, '.min.js');
To:
If (url == 'https://www.paypalobjects.com/api/checkout.js') {
Url = url;
} Else {
Url = url.replace (/ (\. Min)? \. Js $ /, '.min.js');
}}

[AirmanAJK]

Magento CE 2.1.2 here. Is this getting fixed any time soon? Do I really have to choose between hacking a core file, not using minified javascript, or not using PayPal?

[AirmanAJK]

I have a more appropriate solution. Magento 2 has a "minify exclusion list" that can be stored in the core_config_data table.

First make sure there isn't already an entry from some other extension:

select *
from core_config_data ccd
where ccd.path = 'dev/js/minify_exclude';

If there is, you need to append your rule preceded by a line break character (that's what the code splits on).

If it's empty, insert it with a value excluding the paypal checkout file:

insert into core_config_data(scope, scope_id, path, value)
values ('default', 0, 'dev/js/minify_exclude', 'api/checkout');

I believe the proper solution for the Magento devs is to add the following to the Paypal module's config.xml:

<dev>
    <js>
        <minify_exclude>
            api/checkout
        </minify_exclude>
    </js>
</dev>