Improve error reporting for products images import

[leoquijano]

When importing products using the System -> Import Products feature, if there problems importing the images, Magento just fails with:

1. Imported resource (image) could not be downloaded from external resource due to timeout or access permissions in rows: ...

No information is given about the cause of the problem, nor any help for the developer to sort it out. Generic calls to fix permissions don't really help, and it makes the process of importing products way longer than expected.

As explained here, exception handling could be improved to provide helpful messages to the developer. In particular, the following can be added to vendor/magento/module-catalog-import-export/Model/Import/Product.php:

protected function uploadMediaFiles($fileName, $renameFileOff = false)
{
    try {
        $res = $this->_getUploader()->move($fileName, $renameFileOff);
        return $res['file'];
    } catch (\Exception $e) {
        return '';
    }
}

Swallowing exceptions is a very bad thing, so it'd be a good idea to improve it like this:

protected function uploadMediaFiles($fileName, $renameFileOff = false)
{
    try {
        $res = $this->_getUploader()->move($fileName, $renameFileOff);
        return $res['file'];
    } catch (\Exception $e) {
        $this->_logger->critical($e);
        return '';
    }
}

[wert2all]

Please, provide the used version. If the problem is actual for a specific branch, please, specify it and be sure that the latest update was used.

[leoquijano]

Thanks @wert2all. This is branch 2.0, specifically in my case, version 2.0.7:

https://github.com/magento/magento2/blob/2.0/app/code/Magento/CatalogImportExport/Model/Import/Product.php