Validation messages missing from datepicker form elements

[samtay]

Steps to reproduce

1. Install Magento from develop branch.
2. Edit a CMS Page
3. Choose Custom Design From and Custom Design To that are faulty (poorly formatted or such that the end date occurs before the start date.

Expected result

1. See error message generated from validation.js

Actual result

1. In some situations (bad start/end logic or formatting), the validation is caught in JS but you can't see the message on the page. So you can keep clicking "Save" and it will keep focusing on the problematic field, but there is no error message there. It does not exist anywhere in the DOM.
   
2. For other situations (not sure how to replicate), validation is not caught in JS and instead is caught in php POST.
   

[shiftedreality]

Hi @samtay

Looks like you cloned 2.0 branch but not develop. Latest CMS Page has different layout from provided. Could you please verify this issue still actual for you?

[samtay]

You are correct - my screenshots are from EE. However, bad news is that I just cloned develop from this repo and there is a larger problem. The validation is missing, and you can now save a custom_design_from date after a custom_design_to date.

I just looked into this to see if I could send you a quick pull request, as you are missing some of the validation classes. In fact, the recent changes removed date-range validation across the entire framework (for example, cms page design dates).

I thought this would be easy to fix by leveraging existing validation.js rules like this:

<item name="validation" xsi:type="array">
    <item name="validate-date" xsi:type="boolean">true</item>
    <item name="validate-date-range" xsi:type="boolean">true</item>
</item>

and was trying to figure out how to add the class date-range-custom_theme-from to the form element... I can't figure out how to add classes to form fields through the UI components.

BUT this may be a pointless exercise because it looks like the validate-date-range has been removed from the javascript altogether:
. This is confusing because I still see the rule in validation.js but it doesn't appear to be available on the frontend.

[piotrekkaminski]

@elenleonova can you look into it? any reason for validation removal?