Checkout/view/frontend/web/template/billing-address/details.html tries to join street address fields on undefined value

[speedupmate]

Preconditions (*)

1. 2.4.3

Steps to reproduce (*)

1. reach checkout payment step with billing address missing street fields or street field is not a array

Expected result (*)

1. no errors displayed , checkout working

Actual result (*)

1. error logged, all script execution broken

Uncaught TypeError: Unable to process binding "text: function(){return currentBillingAddress().street.join(', ') }"

2. this is caused in https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Checkout/view/frontend/web/template/billing-address/details.html

created with a commit by @rostyslav-hymon on following 53b85cc#diff-e4dcdf0e20375ec650339c4cc63147ff8156a5eb9d2e82e2927d744599d157b5

3. was working before on 2.4.2 (p1 and p2 included) so probably a mixup of template edited as the change is completely lost on git history for this specific line : https://github.com/magento/magento2/blob/2.4.2/app/code/Magento/Checkout/view/frontend/web/template/billing-address/details.html

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ * ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @speedupmate. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[mrtuvn]

Is there any solutions for such case ? Highly interesting this issue

[mrtuvn]

Seem in magento requirejs default use async mode for request scripts

[ihor-sviziev]

@sivaschenko @sidolov @gabrieldagama, this issue should have p1 prio

[speedupmate]

Is there any solutions for such case ? Highly interesting this issue

yes, rewrite/revert in theme scope

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-691 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @sidolov. Thank you for verifying the issue.
Issue Available: @sidolov, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[github-jira-sync-bot]

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-691

[speedupmate]

@engcom-Bravo fake the object from developer tools for your test if you can't find other ways

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 2. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

Hi @speedupmate,

Thank you for reporting the issue.

However, we tried to reproduce it on Magento 2.4-develop, we didn’t find any error in the checkout and the adding/updating billing address.

Steps followed to reproduce issue:

1. Added product to the cart, started the checkout process.
2. Added new billing address, also tried the existing address.
3. Able to checkout successfully.
4. Tried to update billing address using the admin panel but the empty address is not allowed(See below-attached screenshot).

As we are not able to reproduce this issue, hence closing this issue.

Thanks

[speedupmate]

@engcom-Hotel

this is so simple programming ABC I can't even argue here:

1. if you request a property or method from the object and the object does not exist it will fail so currentBillingAddress().street will fail if currentBillingAddress() is "null, undefined, false , or does not have the street property".
2. it was working before and you were spoon fed with the exact line and before and after and pointed to a commit that changes this to be broken

If you can't replicate this then make a condition where you can. Take dev-tools , add a breakpoint , remove the street variable from the object before you hit that line and you are there. This can happen when checkout templates are customised , network has issues as the checkout is not async, it tries to be but the asset loading is still a waterfall and quote object or any object related to it can be undefined, null, object, object with random parameters, object with full parameters, object without methods or full and proper object dependant on page loading and object init sequence .

simplest customisation trough layout file is that you reveal the payment methods on first step , just move the xml to first step and you have it

@ihor-sviziev maybe you can enlighten the team here

[ihor-sviziev]

Maybe @sdzhepa ?

[sdzhepa]

@engcom-Hotel

Could you please review this issue one more time?
also, i noticed that this issue was fixed in the scope https://jira.corp.magento.com/browse/AC-691. PR is created but not merged yet. I assume it means that Issue is reproducible

So, could you pls investigate the situation and bring more clarity to it?

cc: @ihor-sviziev , @speedupmate

[engcom-Hotel]

Hello @sdzhepa @speedupmate @ihor-sviziev

We will look into it and get back to you soon.

Thanks

[hostep]

Since this issue got closed without info, I searched the commits a bit for a reference that mentions "AC-691" and found this one: e2e82b0, hope it helps for people searching for a solution.

[leonhelmus]

@hostep was this resolved in 2.4.5?

[speedupmate]

@leonhelmus yes this is resolved in 2.4.5