Skip to content

Vertex_AddressValidation breaks checkout on billing-validation-mixin.js #33815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks
speedupmate opened this issue Aug 16, 2021 · 3 comments
Closed
4 tasks
Labels
Component: Bundled Extension Issue is caused by one of the bundled extensions Issue: ready for confirmation Reported on 2.4.3 Indicates original Magento version for the Issue report.

Comments

@speedupmate
Copy link
Contributor

speedupmate commented Aug 16, 2021

Preconditions (*)

  1. Magento 2.4.3

Steps to reproduce (*)

  1. if Vertex_AddressValidation is in system but not configured to be used from config
  2. if this mixin is initiated or loaded before quote billing address object is initiated or filled with valid data
  3. it is possible to replicate this by requiring billing-validation-mixin.js before billing address is set, for example requiring vendor/magento/module-checkout/view/frontend/web/js/view/billing-address.js in any component before address data is populated or in a race condition where data is not set.
  4. mixin calls _super() , _super() defines a template , template requires
  5. if data is not valid fails with Uncaught TypeError: Unable to process binding "text: function(){return currentBillingAddress().street.join(', ') }" . Error that breaks all further js execution on site

Expected result (*)

  1. if Vertex_AddressValidation is in system but not configured to be used from config no resources should be included on frontend (Js mixins, path mappings are applied even if modules are not used but are enabled #15967)
  2. no errors on checkout

Actual result (*)

  1. Uncaught TypeError: Unable to process binding "text: function(){return currentBillingAddress().street.join(', ') }"
  2. solution is either to disable this extension with bin/magento module:disable or disable the mixin in any requirejs-config.js file

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ * ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 16, 2021

Hi @speedupmate. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

@magento/ext-vertex, could you take a look?

@ihor-sviziev ihor-sviziev added Component: Bundled Extension Issue is caused by one of the bundled extensions Reported on 2.4.3 Indicates original Magento version for the Issue report. labels Aug 17, 2021
@speedupmate
Copy link
Contributor Author

speedupmate commented Aug 17, 2021

false alarm, only issue left is that its included when not configured but that is not critical

this is what actually causes the issue and due this mixing being the first entry point I missed the details on template change

53b85cc#diff-e4dcdf0e20375ec650339c4cc63147ff8156a5eb9d2e82e2927d744599d157b5

created a new issue for that #33826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Bundled Extension Issue is caused by one of the bundled extensions Issue: ready for confirmation Reported on 2.4.3 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

2 participants