JS error in console on checkout when recaptcha for checkout/placing order is not enabled #33741

basvanpoppel · 2021-08-10T20:17:57Z

Preconditions (*)

Magento 2.4.3
'Stores > Configuration > Security > Google reCAPTCHA Storefront > Storefront > Enable for Checkout/Placing Order' set to 'No' (that's the default config)

Steps to reproduce (*)

Add a product to cart
Go to checkout
Open element inspector, see the JS error

Expected result (*)

No JS errors on checkout
Besides not wanting to run into errors, I wouldn't expect checkout to load any recaptcha JS when all the recaptcha options are not enabled.

Actual result (*)

Error message from recaptcha JS:

knockout.js:3753 Uncaught TypeError: Unable to process binding "afterRender: function(){return renderReCaptcha() }"
Message: Cannot read property 'rendering' of undefined
    at UiClass.initCaptcha (reCaptcha.js:117)
    at UiClass.renderReCaptcha (reCaptcha.js:182)
    at afterRender (eval at createBindingsStringEvaluator (knockout.js:3221), <anonymous>:3:134)
    at init (after-render.js:17)
    at knockout.js:3730
    at Object.ignore (knockout.js:1563)
    at knockout.js:3729
    at Object.arrayForEach (knockout.js:168)
    at applyBindingsToNodeInternal (knockout.js:3715)
    at applyBindingsToNodeAndDescendantsInternal (knockout.js:3573)

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

Severity: S0 - Affects critical data or functionality and leaves users without workaround.
Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

ps. I think severity should be higher, because any dev working om checkout will spot this, and will be looking for a fix. (I first checked all of my modules, themes and 3rd party modules: it's time consuming.)

The text was updated successfully, but these errors were encountered:

m2-assistant · 2021-08-10T20:17:59Z

Hi @basvanpoppel. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mrtuvn · 2021-08-11T00:59:20Z

Can you proceed checkout with this js error?

mrtuvn · 2021-08-11T01:52:57Z

Not actually blocker but turn out even you not enable settings (Set NO) but code base still check it by default

onlinebizsoft · 2021-08-11T02:54:40Z

bug reported too fast :)

magento-engcom-team · 2021-08-11T03:26:08Z

✅ Confirmed by @mrtuvn
Thank you for verifying the issue. Based on the provided information internal tickets MC-43053 were created

Issue Available: @mrtuvn, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

mrtuvn · 2021-08-11T03:28:31Z

Hi @basvanpoppel Is P3 priority correct for such case ?

mrtuvn · 2021-08-11T03:59:36Z

Component: Recaptcha

basvanpoppel · 2021-08-11T06:41:19Z

Hi @mrtuvn I would give it P2: Checkout doesn't break (the recaptcha component isn't used, so the JS error doesn't actually hurt) it's not critical and no work-around is needed, which follows P3 description.

But this is awful for developers working on checkout: I have several custom ui components, layout processors and mixins on any checkout i work on. If there's an issue after upgrading, I will first look at my customisations, then at third party modules, then Magento.

Imagine every dev going through this process after seeing this issue, that's a lot of wasted time - and a lot of unhappy devs.

basvanpoppel · 2021-08-11T07:04:01Z

I'm working on a PR for this.

chequille · 2021-08-11T19:43:39Z

New version new bug. I would sugest to set it P1 or better P -100 !?!?!?!?!
Facing the same probllem and it is ugly to have errors even if they do not break the checkout process.

My opinion
Chequille

speedupmate · 2021-08-16T14:03:52Z

In addition to this:

adds a global place order mixin . what this does is that even if functionality is not configured , mixins are added in all cases see : Js mixins, path mappings are applied even if modules are not used but are enabled #15967
mixin has a hardcoded dependency to Magento_ReCaptchaWebapiUi not mentioned in module.xml that extension itself adds a mixin to jquery .o0 see: Js mixins, path mappings are applied even if modules are not used but are enabled #15967
adds a afterRender call to template forcing to init this functionality even if not configured or needed or each time the template is rendered , bad practice and hard UI dependency

speedupmate · 2021-08-16T14:14:00Z

Hi @mrtuvn I would give it P2: Checkout doesn't break (the recaptcha component isn't used, so the JS error doesn't actually hurt) it's not critical and no work-around is needed, which follows P3 description.

@basvanpoppel ? install a clean instance of m2 you can't checkout cause of those issues without reCaptcha configuration being enabled and valid means Magento2 does not work out of the box.

By default if extension is in system and is not configured to be used should mean no assets are included in storefront at all. Aim for this in your PR, thanks.

dudzio12 · 2021-08-16T14:22:00Z

Fix for the impatient (Magento composer installations).

@basvanpoppel -this implements your suggested PR (magento/security-package#302) changes :)

/patches/composer/github-issue-33741.diff

diff --git a/Block/LayoutProcessor/Checkout/Onepage.php b/Block/LayoutProcessor/Checkout/Onepage.php
index 390bf712..b2d5b777 100644
--- a/Block/LayoutProcessor/Checkout/Onepage.php
+++ b/Block/LayoutProcessor/Checkout/Onepage.php
@@ -79,7 +79,8 @@ class Onepage implements LayoutProcessorInterface
             ['place-order-recaptcha']['settings'] = $this->captchaUiConfigResolver->get($key);
         } else {
             if (isset($jsLayout['components']['checkout']['children']['steps']['children']['billing-step']['children']
-                ['payment']['children']['beforeMethods']['children']['place-order-recaptcha'])) {
+                ['payment']['children']['beforeMethods']['children']['place-order-recaptcha-container']['children']
+                ['place-order-recaptcha'])) {
                 unset($jsLayout['components']['checkout']['children']['steps']['children']['billing-step']['children']
                     ['payment']['children']['beforeMethods']['children']['place-order-recaptcha-container']
                     ['children']['place-order-recaptcha']);
@@ -89,3 +90,4 @@ class Onepage implements LayoutProcessorInterface
         return $jsLayout;
     }
 }
+

/composer.json

{
(...)
    "extra": {
        (...)
        "patches": {
            (...)
            "magento/module-re-captcha-checkout": {
                "Fixed checkout reCaptcha disabling #33741": "patches/composer/github-issue-33741.diff"
            }
        }
    }
}

speedupmate · 2021-08-16T14:51:37Z

@basvanpoppel @dudzio12 although good effort it does not free you from all the loaded reCaptcha mixins defined in following files, those will still wrap what they wrap enabled/disabled layout nodes included or not

vendor/magento/module-re-captcha-paypal/view/frontend/requirejs-config.js 
vendor/magento/module-re-captcha-webapi-ui/view/frontend/requirejs-config.js
vendor/magento/module-re-captcha-frontend-ui/view/frontend/requirejs-config.js
vendor/magento/module-re-captcha-checkout/view/frontend/requirejs-config.js

it mostly means that even if recaptchas are not used your default behaviour is wrapped and no other module tests for those wrapped conditions and mostly assume that defaults are used

dudzio12 · 2021-08-16T15:30:17Z

@basvanpoppel That's understandable of course, I needed patch to kickstart my project's upgrades, so it is what it is.

I'm still looking forward for you to complete the PR :)

Then I will prepare another patch to fix the issue.

@mrtuvn What is the politics on P2 bug fixes? It will be released as separate patch, next patch release -p1 or in the next minor release?

mrtuvn · 2021-08-16T15:46:53Z

p2 label is lower priority than p1/p0. It's depend on specific case of ticket. It's not related with fix order deliver to next release. i'm not sure magento team will deliver this fixes as patch (seperate) or regular fix as normal.
I saw a pull request related in the case owner disabled captcha from backend but captcha js files still request from server. But we already have PR for that here
Put here for anyone interesting #33200.
In this specific issue imho captcha js should only available if user put both user/key pair value in backend

basvanpoppel · 2021-08-17T20:43:39Z

@mrtuvn this issue still has 'ready for dev' status, while this pr should be in the review process, I think: magento/security-package#302

@speedupmate This PR just fixes this specific issue. Preventing other modules from adding wrappers isn't my goal here. If you know of a better way to fix this issue, please share it.

speedupmate · 2021-08-18T06:40:23Z

@speedupmate This PR just fixes this specific issue. Preventing other modules from adding wrappers isn't my goal here. If you know of a better way to fix this issue, please share it.

Part of this is the layoutprocessor style config you are trying to add but with a plugin to requirejs-config collection class to just exclude non-configured extension files on matching conditions (like enabled/disabled , auth failing etc).

Even better would be stopping popularising mixins as a main go to weapon in devdocs for editing/wrapping component functionality as this is really a sledgehammer that affects wider scope than usual extension tries to cover.

hostep · 2021-09-23T18:35:13Z

@chittima: could you leave some more detailed info please? Like providing commits that fixed this. Just closing an issue with so little explanation is a bit rude ...
Also: have you tested this while magento/security-package was installed? The comments above seem to indicate that the bug is part of that package.

sdzhepa · 2021-09-23T19:59:31Z

Hello @hostep @mrtuvn @glevhen

Let me try to shade more lite on the issue based on communication and collaboration in the internal Jira ticket.

recently Jira ticket related to this public report was taken into the sprint scope by one of the internal teams
But on the initial phase, a QA engineer was not able to reproduce this issue on the latest 2.4-develop branch with security-package installed
also issue cannot be reproduced on the 2.4.3-p1

Based on such verification, the ticket was closed by QA with the resolution "cannot reproduce" - according to workflow.
It looks like the problem was already fixed in the scope of some other PRs/commits/tasks etc.

If you still experience a similar issue on the latest version of code I would recommend opening a new issue with updated versions/steps and actual/expected results

chequille · 2021-09-23T20:51:37Z

Unbelievable !!!!
we need the information what is finally be done to fix this issue.
We do not want to wait till 2.4.3-p1 is out as it could take a few weeks/months till it is released.

hostep · 2021-09-23T21:41:55Z

It's actually pretty close, the release of 2.4.3-p1 😉

Thanks @sdzhepa for the extra info, however it would still be nice if somebody could figure out how it got fixed.

lytesaber · 2021-10-13T04:49:21Z

Just updated from 2.4.3 to 2.4.3-p1 and still experiencing this error in checkout unless reCAPTCHA is configured.

Errors being thrown due to optional configuration not being configured wastes a lot of time. As covered above when updating between versions going through a smashing any log exceptions or console errors thrown post upgrade is standard process and this error in checkout is just another distraction and another pointless issue to investigate. I don't know why errors are seen as acceptable, when the goal should be 0 errors and warnings.

Is there actually going to be a fix put in place for this?

engcom-November · 2021-10-14T12:07:27Z

Verified this issue on Magento 2.4-develop and 2.4.3 versions and the issue is not reproducible on 2.4-develop branch but is reproducible on 2.4.3 version:

sdzhepa · 2021-10-14T21:07:04Z

@engcom-November
Could you please check it on the 2.4.3-p1 release? (it is the lates release)

sdzhepa · 2021-10-14T21:09:30Z

magento/security-package#302

engcom-November · 2021-10-18T11:07:57Z

Verified the issue on 2.4.3-p1 version as well and the issue is reproducible:

nicholasscottfish · 2021-10-22T13:01:03Z

@engcom-November

Do we expect a patch to be released soon?

nathanjosiah · 2021-10-28T18:17:46Z

Fix merged in https://github.com/magento-commerce/security-package/pull/54 (magento/security-package#302)

Kerlitek · 2021-11-02T11:49:31Z

Just a link for those looking for the actual SOLUTION magento/security-package@d25432d

jesperingels · 2022-02-03T14:20:17Z

For anyone looking for a patch on Magento v2.4.3-p1

github-issue-33741.patch

diff --git a/vendor/magento/module-re-captcha-checkout/Block/LayoutProcessor/Checkout/Onepage.php b/vendor/magento/module-re-captcha-checkout/Block/LayoutProcessor/Checkout/Onepage.php
index 3ee2rd..8349152 111644
--- a/vendor/magento/module-re-captcha-checkout/Block/LayoutProcessor/Checkout/Onepage.php
+++ b/vendor/magento/module-re-captcha-checkout/Block/LayoutProcessor/Checkout/Onepage.php
@@ -79,7 +79,8 @@
             ['place-order-recaptcha']['settings'] = $this->captchaUiConfigResolver->get($key);
         } else {
             if (isset($jsLayout['components']['checkout']['children']['steps']['children']['billing-step']['children']
-                ['payment']['children']['beforeMethods']['children']['place-order-recaptcha'])) {
+                ['payment']['children']['beforeMethods']['children']['place-order-recaptcha-container']['children']
+                ['place-order-recaptcha'])) {
                 unset($jsLayout['components']['checkout']['children']['steps']['children']['billing-step']['children']
                     ['payment']['children']['beforeMethods']['children']['place-order-recaptcha-container']
                     ['children']['place-order-recaptcha']);

erfanimani · 2022-04-12T02:51:06Z

I would have expected this to be released as a Magento Quality Patch, or is this issue too small for that?

Aquive · 2022-09-19T09:20:27Z

~~I still have this issue on Magento 2.4.5~~ It is solved in 2.4.5

m2-community-project bot added the Issue: ready for confirmation label Aug 10, 2021

mrtuvn added the Reported on 2.4.3 Indicates original Magento version for the Issue report. label Aug 11, 2021

mrtuvn added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 11, 2021

m2-community-project bot removed the Issue: ready for confirmation label Aug 11, 2021

mrtuvn added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Aug 11, 2021

m2-community-project bot added the Progress: ready for dev label Aug 11, 2021

basvanpoppel mentioned this issue Aug 11, 2021

Fix check if place-order-recaptcha component is set magento/security-package#302

Closed

5 tasks

mrtuvn added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Aug 11, 2021

basvanpoppel changed the title ~~JS error in console on checkout when if recaptcha for checkout/placing order is not enabled~~ JS error in console on checkout when recaptcha for checkout/placing order is not enabled Aug 11, 2021

github-jira-sync-bot added Progress: done and removed Progress: ready for dev labels Sep 23, 2021

m2-community-project bot closed this as completed Sep 23, 2021

sdzhepa reopened this Oct 13, 2021

m2-community-project bot added Progress: ready for dev and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Progress: done labels Oct 13, 2021

nathanjosiah closed this as completed Oct 28, 2021

m2-community-project bot added Progress: done and removed Progress: ready for dev labels Oct 28, 2021

ihor-sviziev mentioned this issue Dec 1, 2021

Js mixins, path mappings are applied even if modules are not used but are enabled #15967

Open

plastikschnitzer mentioned this issue Apr 5, 2022

Checkout with PayPal throws a "Something went wrong ......" error #28092

Closed

engcom-Hotel added this to High Priority Backlog Aug 19, 2024

engcom-Hotel moved this to Done in High Priority Backlog Aug 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JS error in console on checkout when recaptcha for checkout/placing order is not enabled #33741

JS error in console on checkout when recaptcha for checkout/placing order is not enabled #33741

basvanpoppel commented Aug 10, 2021 •

edited

Loading

m2-assistant bot commented Aug 10, 2021

mrtuvn commented Aug 11, 2021

mrtuvn commented Aug 11, 2021 •

edited

Loading

onlinebizsoft commented Aug 11, 2021

magento-engcom-team commented Aug 11, 2021

mrtuvn commented Aug 11, 2021

mrtuvn commented Aug 11, 2021

basvanpoppel commented Aug 11, 2021

basvanpoppel commented Aug 11, 2021

chequille commented Aug 11, 2021

speedupmate commented Aug 16, 2021 •

edited

Loading

speedupmate commented Aug 16, 2021

dudzio12 commented Aug 16, 2021 •

edited

Loading

speedupmate commented Aug 16, 2021 •

edited

Loading

dudzio12 commented Aug 16, 2021

mrtuvn commented Aug 16, 2021 •

edited

Loading

basvanpoppel commented Aug 17, 2021 •

edited

Loading

speedupmate commented Aug 18, 2021

hostep commented Sep 23, 2021 •

edited

Loading

sdzhepa commented Sep 23, 2021

chequille commented Sep 23, 2021

hostep commented Sep 23, 2021

lytesaber commented Oct 13, 2021

engcom-November commented Oct 14, 2021

sdzhepa commented Oct 14, 2021

sdzhepa commented Oct 14, 2021

engcom-November commented Oct 18, 2021

nicholasscottfish commented Oct 22, 2021

nathanjosiah commented Oct 28, 2021 •

edited

Loading

Kerlitek commented Nov 2, 2021 •

edited

Loading

jesperingels commented Feb 3, 2022

erfanimani commented Apr 12, 2022

Aquive commented Sep 19, 2022 •

edited

Loading

JS error in console on checkout when recaptcha for checkout/placing order is not enabled #33741

JS error in console on checkout when recaptcha for checkout/placing order is not enabled #33741

Comments

basvanpoppel commented Aug 10, 2021 • edited Loading

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

m2-assistant bot commented Aug 10, 2021

mrtuvn commented Aug 11, 2021

mrtuvn commented Aug 11, 2021 • edited Loading

onlinebizsoft commented Aug 11, 2021

magento-engcom-team commented Aug 11, 2021

mrtuvn commented Aug 11, 2021

mrtuvn commented Aug 11, 2021

basvanpoppel commented Aug 11, 2021

basvanpoppel commented Aug 11, 2021

chequille commented Aug 11, 2021

speedupmate commented Aug 16, 2021 • edited Loading

speedupmate commented Aug 16, 2021

dudzio12 commented Aug 16, 2021 • edited Loading

speedupmate commented Aug 16, 2021 • edited Loading

dudzio12 commented Aug 16, 2021

mrtuvn commented Aug 16, 2021 • edited Loading

basvanpoppel commented Aug 17, 2021 • edited Loading

speedupmate commented Aug 18, 2021

hostep commented Sep 23, 2021 • edited Loading

sdzhepa commented Sep 23, 2021

chequille commented Sep 23, 2021

hostep commented Sep 23, 2021

lytesaber commented Oct 13, 2021

engcom-November commented Oct 14, 2021

sdzhepa commented Oct 14, 2021

sdzhepa commented Oct 14, 2021

engcom-November commented Oct 18, 2021

nicholasscottfish commented Oct 22, 2021

nathanjosiah commented Oct 28, 2021 • edited Loading

Kerlitek commented Nov 2, 2021 • edited Loading

jesperingels commented Feb 3, 2022

erfanimani commented Apr 12, 2022

Aquive commented Sep 19, 2022 • edited Loading

basvanpoppel commented Aug 10, 2021 •

edited

Loading

mrtuvn commented Aug 11, 2021 •

edited

Loading

speedupmate commented Aug 16, 2021 •

edited

Loading

dudzio12 commented Aug 16, 2021 •

edited

Loading

speedupmate commented Aug 16, 2021 •

edited

Loading

mrtuvn commented Aug 16, 2021 •

edited

Loading

basvanpoppel commented Aug 17, 2021 •

edited

Loading

hostep commented Sep 23, 2021 •

edited

Loading

nathanjosiah commented Oct 28, 2021 •

edited

Loading

Kerlitek commented Nov 2, 2021 •

edited

Loading

Aquive commented Sep 19, 2022 •

edited

Loading