New Invoice: Checkbox "Email Copy of Invoice" is useless

[TerrapinSoftware]

Preconditions (*)

1. 2.3.5-p1
2. Magento 2.4-develop

Steps to reproduce (*)

1. Go to Admin -> Stores -> Configuration -> Sales -> Sales Emails -> Invoice:
   set Enable to Yes;
   set Send Invoice Email Copy To to test@example.com
2. Create Order;
3. Go to Admin -> Sales -> Orders and open created before order for edit;
4. Click on the Invoice button;
5. Uncheck "Email Copy of Invoice";
6. Generate Invoice;

Expected result (*)

1. Email should not be sent to anyone

Actual result (*)

1. Email sent both to Customer and Copy To

The behavior changed from M1 to M2. Regardless if you check that checkbox or not, the email is sent to both the customer and the Copy To address. If you disable the sending of invoices in the Config section, there is no way to send invoice emails at all, because the "Send Email" button in the View Invoice screen does nothing, and the checkbox is not displayed in the New Invoice section.

Looking at the source code, I find this in vendor/magento/module-sales/Controller/Adminhtml/Order/Invoice/Save.php, line 216:

if (!empty($data['send_email']) || $this->salesData->canSendNewInvoiceEmail()) {
    $this->invoiceSender->send($invoice);

Looks good so far; if the config is "off", the checkbox would override the setting.

Unfortunately, the checkbox is not displayed at all when the config is "off".

Even if the checkbox would be visible, emails would not be sent, because in the file vendor/magento/module-sales/Model/Order/Email/Sender/InvoiceSender.php at line 101, I find this:

public function send(Invoice $invoice, $forceSyncMode = false)
{
    $invoice->setSendEmail($this->identityContainer->isEnabled());

This picks up the "off" value from the config, thus overriding any checkbox value again.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [*] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @TerrapinSoftware. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @VigneshVenkatesan154. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[TerrapinSoftware]

OK. I see that this bug is very, very difficult to fix. Here is the fix.

In file vendor/magento/module-sales/Controller/Adminhtml/Order/Invoice/Save.php, line 216, replace

if (!empty($data['send_email']) || $this->salesData->canSendNewInvoiceEmail()) {
    $this->invoiceSender->send($invoice);

with

if (!empty($data['send_email']) && $this->salesData->canSendNewInvoiceEmail()) {
    $this->invoiceSender->send($invoice);

Change || to &&.

Also change line #225 from

if (!empty($data['send_email']) || $this->salesData->canSendNewShipmentEmail()) {
    $this->shipmentSender->send($shipment);

to

if (!empty($data['send_email']) && $this->salesData->canSendNewShipmentEmail()) {
    $this->shipmentSender->send($shipment);

[kamal02mittal]

Yes, I have also applied the same
replaced below

if (!empty($data['send_email']) || $this->salesData->canSendNewInvoiceEmail()) {
    $this->invoiceSender->send($invoice);

With

if (!empty($data['send_email']) && $this->salesData->canSendNewInvoiceEmail()) {
    $this->invoiceSender->send($invoice);

OR

if (!empty($data['send_email'])) {
    $this->invoiceSender->send($invoice);

But we need to override this controller in our custom module to do the same.