Can't create/reset user password if user address is not valid

[rafal-kos]

Preconditions (*)

1. Magento 2.4-develop
2. Open Create New Account Options and enable Require Emails Confirmation
3. Create user with address (no special validation) via admin

Steps to reproduce (*)

1. Add some kind of validation to address fields (limit length for city name)

UPDATE customer_eav_attribute SET validate_rules='{"input_validation":1,"min_text_length":0,"max_text_length":2}'
WHERE attribute_id=(SELECT attribute_id FROM eav_attribute WHERE entity_type_id=2 AND attribute_code='city');

OR for example you could create a plugin beforeSave on \Magento\Customer\Api\AddressRepositoryInterface that will add custom validation of address data.
2. Go to frontend
3. Click Sign In
4. Click Forgot Your Password?
5. Fill fields and click Reset My Password
6. Open email and click Set a New Password

Expected result (*)

1. Forgot password functionality should allow the user to reset password
2. Address data shouldn't be used in reset password process

Actual result (*)

1. You will be redirected to Forgot Your Password? page

Problem is in class Magento\Customer\Model\ForgotPasswordToken\ConfirmCustomerByToken in method execute which runs save on customer object.

We should disable address validation in this process or make an error message more clear for user.

[m2-assistant]

Hi @rafal-kos. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@rafal-kos do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[sheepfy]

i can take this one :)

[m2-assistant]

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.