reindexList does not use batch processing

[dmanners]

Preconditions (*)

1. Magento Version 2.2.5
2. 4000 products,
3. 41 stores
4. 42 store groups,
5. 6 websites,

Steps to reproduce (*)

1. Programatically reindex a limited set of products with the following,

$productIndexer = $this->indexerRegistry->get(\Magento\Catalog\Model\Indexer\Product\Eav\Processor::INDEXER_ID);
$category = $this->categoryRepository->get(
    $categoryId,
    $storeId
);
$productCollection = $category->getProductCollection();
$productIds = $productCollection->getAllIds();
$productIndexer->reindexList($productIds);

Expected result (*)

1. Reindex to be successfully completed,

Actual result (*)

1. Error given: The table 'catalog_product_index_eav_temp' is full

After diving into the issue I noticed that calling $productIndexer->reindexAll(); does not have this problem. It looks like the built in batch processing only happens when reindexing all products and not a sub set.

For full indexing see: https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Catalog/Model/Indexer/Product/Eav/Action/Full.php#L112
For partial indexing see: https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Catalog/Model/Indexer/Product/Eav/Action/Rows.php#L21

For our case I have added our own batch processing around the reindexList call but I wonder if this is something that should be taken over by the Magento index batching that already gets used.

[m2-assistant]

Hi @dmanners. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@dmanners do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[dmanners]

There is a similar closed issue but around the reindexAll method and an older version of Magento: #6415

[dmanners]

If it turns out that it should be batched in the same way that the reindexAll is batched then I would be happy to take this on as contribution with some input and direction from the arch team.

[m2-assistant]

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Charlie]

Hello @dmanners
We are not able to reproduce this issue on the latest 2.3-develop branch by provided steps.

Code used:

$categoryId = 3;
$storeId = 1;
$objectManager = Magento\Framework\App\ObjectManager::getInstance();
$indexerRegistry = $objectManager->get('Magento\Framework\Indexer\IndexerRegistry');
$productIndexer = $indexerRegistry->get(\Magento\Catalog\Model\Indexer\Product\Eav\Processor::INDEXER_ID);
$categoryRepository = $objectManager->get('\Magento\Catalog\Model\CategoryRepository');
$category = $categoryRepository->get(
    $categoryId,
    $storeId
);
$productCollection = $category->getProductCollection();

$productIds = $productCollection->getAllIds();

$productIndexer->reindexList($productIds);

Result:
Re-index to be successfully completed without any errors or exceptions.

We are closing this issue due to branch 2.2-develop was closed and

Magento no longer accepts pull requests and issues to the v2.2 release lines to focus all development efforts on v2.3.

Thanks for your report!