-
Notifications
You must be signed in to change notification settings - Fork 9.4k
RSS Feed - first load not working #25211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @JuraseQ. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @JuraseQ do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @engcom-Charlie. Thank you for working on this issue.
|
✅ Confirmed by @engcom-Charlie Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hi @eduard13. Thank you for working on this issue.
|
Hi @osrecio. Thank you for working on this issue.
|
✅ Confirmed by @sdzhepa Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hi @engcom-Charlie. Thank you for working on this issue.
|
Hi @JuraseQ. Thank you for your report.
The fix will be available with the upcoming 2.4.1 release. |
Uh oh!
There was an error while loading. Please reload this page.
Preconditions (*)
Steps to reproduce (*)
Enable standard RSS Feed module.
Enable RSS Feed for New Products and Special Products.

Proceed to domain.tld/rss

Choose any channel.(New product in my case)
We get an exception

Refresh of site will make RSS Feed work. The point is that it's not working every time after compile.

Expected result (*)
Actual result (*)
What i found (*)
I debugged it and in Zend\Feed\Writer\AbstractFeed in method setTitle there is condition:
if ((empty($title) && ! is_numeric($title)) || ! is_string($title)) { throw new Exception\InvalidArgumentException('Invalid parameter: parameter must be a non-empty string'); }
$title is an instance of 'Magento\Framework\Phrase' that is why it's throwing an exception.
When i changed the condition to:
if ((empty($title) && ! is_numeric($title)) || (! is_string($title) && strpos(get_class($title), 'Magento\Framework\Phrase') === false)) {
I tried this way just temporary for tests but it will require to modify data before it will reach Zend's library method.
The text was updated successfully, but these errors were encountered: