🔃 [EngCom] Public Pull Requests - 2.2-develop

Accepted Public Pull Requests:
 - #19002: [Backport] Remove duplicated CSS selector (by @dmytro-ch)
 - #19074: [Backport] Fix for #12399: Exception Error in Catalog Price Rule while Backend language is not English (by @Mardl)
 - #19044: [2.2-develop] #14007: "Use in Layered Navigation: Filterable (no results)" property confuse for Price filter (by @vpodorozh)
 - #18985: [Backport] Added form fieldset before html data to \Magento\Framework\Data\Form\Element\Fieldset in getElementHtml() method (by @vasilii-b)


Fixed GitHub Issues:
 - #12399: Exception Error in Catalog Price Rule while Backend language is not English (reported by @Drakas) has been fixed in #19074 by @Mardl in 2.2-develop branch
   Related commits:
     1. a5a0b0b

 - #14007: "Use in Layered Navigation: Filterable (no results)" not working for `Price` attribute. (reported by @yogeshks) has been fixed in #19044 by @vpodorozh in 2.2-develop branch
   Related commits:
     1. 52bfffc

 - #2618: Class \Magento\Framework\Data\Form\Element\Fieldset breaks specification of the parent class \Magento\Framework\Data\Form\Element\AbstractElement by not calling the method getBeforeElementHtml (getAfterElementHtml is called) (reported by @dmitry-fedyuk) has been fixed in #18985 by @vasilii-b in 2.2-develop branch
   Related commits:
     1. 6629445

Author: magento-engcom-team

app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog/Save.php

@@ -60,6 +60,17 @@ public function execute()
                     ['request' => $this->getRequest()]
                 );
                 $data = $this->getRequest()->getPostValue();
+
+                $filterValues = ['from_date' => $this->_dateFilter];
+                if ($this->getRequest()->getParam('to_date')) {
+                    $filterValues['to_date'] = $this->_dateFilter;
+                }
+                $inputFilter = new \Zend_Filter_Input(
+                    $filterValues,
+                    [],
+                    $data
+                );
+                $data = $inputFilter->getUnescaped();
                 $id = $this->getRequest()->getParam('rule_id');
                 if ($id) {
                     $model = $ruleRepository->get($id);

app/code/Magento/LayeredNavigation/Observer/Edit/Tab/Front/ProductAttributeFormBuildFrontTabObserver.php

@@ -55,7 +55,11 @@ public function execute(\Magento\Framework\Event\Observer $observer)
                 'name' => 'is_filterable',
                 'label' => __("Use in Layered Navigation"),
                 'title' => __('Can be used only with catalog input type Yes/No, Dropdown, Multiple Select and Price'),
-                'note' => __('Can be used only with catalog input type Yes/No, Dropdown, Multiple Select and Price.'),
+                'note' => __(
+                    'Can be used only with catalog input type Yes/No, Dropdown, Multiple Select and Price.
+                    <br>Price is not compatible with <b>\'Filterable (no results)\'</b> option - 
+                     it will make no affect on Price filter.'
+                ),
                 'values' => [
                     ['value' => '0', 'label' => __('No')],
                     ['value' => '1', 'label' => __('Filterable (with results)')],

app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/_cart.less

@@ -630,12 +630,9 @@
                     width: 1%;
                 }
 
-                &-item-details {
-                    padding-bottom: 35px;
-                }
-
                 &-item-details {
                     display: table-cell;
+                    padding-bottom: 35px;
                     vertical-align: top;
                     white-space: normal;
                     width: 99%;

lib/internal/Magento/Framework/Data/Form/Element/Fieldset.php

@@ -43,7 +43,8 @@ public function __construct(
      */
     public function getElementHtml()
     {
-        $html = '<fieldset id="' . $this->getHtmlId() . '"' . $this->serialize(
+        $html = $this->getBeforeElementHtml();
+        $html .= '<fieldset area-hidden="false" id="' . $this->getHtmlId() . '"' . $this->serialize(
             ['class']
         ) . $this->_getUiId() . '>' . "\n";
         if ($this->getLegend()) {