🔃 [EngCom] Public Pull Requests - 2.2-develop

Accepted Public Pull Requests:
 - #20929: resolve typo errors for js record.js (by @neeta-wagento)
 - #20837: [Backport] Fixed apply discount button alignment on checkout page (by @amol2jcommerce)
 - #20886: [Backport] #20409 Fixed Unnecessary slash in namespace (by @milindsingh)
 - #20863: [Backport] Update Filter.php fix issue #20624 (by @irajneeshgupta)
 - #20784: [Backport] Gift-option-message-overlap-edit-and-remove-button-2.2 (by @ajay2jcommerce)
 - #20642: [Backport] #12194: Tier price on configurable product sorting so� (by @amol2jcommerce)
 - #19612: [Backport] Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero [REST API] (by @SikailoISM)
 - #19667: [Backport] chore: remove old code for IE9 (by @DanielRuf)


Fixed GitHub Issues:
 - #20137: On checkout page apply discount button is not align with input box (reported by @nainesh2jcommerce) has been fixed in #20837 by @amol2jcommerce in 2.2-develop branch
   Related commits:
     1. 4a3354a
     2. 1a75856
     3. 496c6af

 - #20409: Magento\Catalog\Api\ProductRenderListInterface returns products regardless of visibility (reported by @Floddy) has been fixed in #20886 by @milindsingh in 2.2-develop branch
   Related commits:
     1. 9092e7a

 - #20624: `\Magento\ImportExport\Block\Adminhtml\Export\Filter::_getSelectHtmlWithValue()` method overwrites self $value argument (reported by @andkirby) has been fixed in #20863 by @irajneeshgupta in 2.2-develop branch
   Related commits:
     1. 05bc8a6
     2. 34da4ca

 - #20604: Gift option message overlap edit and remove button (reported by @ajay2jcommerce) has been fixed in #20784 by @ajay2jcommerce in 2.2-develop branch
   Related commits:
     1. adf8d4c

 - #19436: Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)) (reported by @zexperto) has been fixed in #19612 by @SikailoISM in 2.2-develop branch
   Related commits:
     1. 14aa091

Author: magento-engcom-team

app/code/Magento/Catalog/Model/Product/Attribute/OptionManagement.php

@@ -47,7 +47,7 @@ public function add($attributeCode, $option)
                 /** @var \Magento\Eav\Api\Data\AttributeOptionInterface $attributeOption */
                     $attributeOption = $attributeOption->getLabel();
             });
-            if (in_array($option->getLabel(), $currentOptions)) {
+            if (in_array($option->getLabel(), $currentOptions, true)) {
                 return false;
             }
         }

app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php

@@ -2205,7 +2205,7 @@ private function getTierPriceSelect(array $productIds)
             $this->getLinkField() . ' IN(?)',
             $productIds
         )->order(
-            $this->getLinkField()
+            'qty'
         );
         return $select;
     }

app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/Product/CollectionTest.php

@@ -318,7 +318,7 @@ public function testAddTierPriceDataByGroupId()
                 [ '(customer_group_id=? AND all_groups=0) OR all_groups=1', $customerGroupId]
             )
             ->willReturnSelf();
-        $select->expects($this->once())->method('order')->with('entity_id')->willReturnSelf();
+        $select->expects($this->once())->method('order')->with('qty')->willReturnSelf();
         $this->connectionMock->expects($this->once())
             ->method('fetchAll')
             ->with($select)
@@ -370,7 +370,7 @@ public function testAddTierPriceData()
         $select->expects($this->exactly(1))->method('where')
             ->with('entity_id IN(?)', [1])
             ->willReturnSelf();
-        $select->expects($this->once())->method('order')->with('entity_id')->willReturnSelf();
+        $select->expects($this->once())->method('order')->with('qty')->willReturnSelf();
         $this->connectionMock->expects($this->once())
             ->method('fetchAll')
             ->with($select)

app/code/Magento/CatalogInventory/etc/di.xml

@@ -111,7 +111,7 @@
             <argument name="batchSizeManagement" xsi:type="object">Magento\CatalogInventory\Model\Indexer\Stock\BatchSizeManagement</argument>
         </arguments>
     </type>
-    <type name="\Magento\Framework\Data\CollectionModifier">
+    <type name="Magento\Framework\Data\CollectionModifier">
         <arguments>
             <argument name="conditions" xsi:type="array">
                 <item name="stockStatusCondition" xsi:type="object">Magento\CatalogInventory\Model\ProductCollectionStockCondition</item>

app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php

@@ -236,8 +236,8 @@ protected function _getSelectHtmlWithValue(Attribute $attribute, $value)
         if ($attribute->getFilterOptions()) {
             $options = [];
 
-            foreach ($attribute->getFilterOptions() as $value => $label) {
-                $options[] = ['value' => $value, 'label' => $label];
+            foreach ($attribute->getFilterOptions() as $optionValue => $label) {
+                $options[] = ['value' => $optionValue, 'label' => $label];
             }
         } else {
             $options = $attribute->getSource()->getAllOptions(false);

app/code/Magento/Ui/view/base/web/js/dynamic-rows/record.js

@@ -25,7 +25,7 @@ define([
             },
             listens: {
                 position: 'initPosition',
-                elems: 'setColumnVisibileListener'
+                elems: 'setColumnVisibleListener'
             },
             links: {
                 position: '${ $.name }.${ $.positionProvider }:value'
@@ -123,7 +123,7 @@ define([
         /**
          * Set column visibility listener
          */
-        setColumnVisibileListener: function () {
+        setColumnVisibleListener: function () {
             var elem = _.find(this.elems(), function (curElem) {
                 return !curElem.hasOwnProperty('visibleListener');
             });

app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/checkout/_payment-options.less

@@ -69,6 +69,13 @@
 
         .payment-option-content {
             .lib-css(padding, 0 0 @indent__base @checkout-payment-option-content__padding__xl);
+            .primary {
+                .action {
+                    &.action-apply {
+                        margin-right: 0;
+                    }
+                }
+            }
         }
 
         .payment-option-inner {

app/design/frontend/Magento/luma/Magento_GiftMessage/web/css/source/_module.less

@@ -246,6 +246,10 @@
     .gift-messages-order {
         margin-bottom: @indent__m;
     }
+
+    .gift-message-summary {
+        padding-right: 7rem;
+    }
 }
 
 //
@@ -282,10 +286,6 @@
         }
     }
 
-    .gift-message-summary {
-        padding-right: 7rem;
-    }
-
     //
     //  In-table block
     //  ---------------------------------------------

lib/web/varien/js.js

@@ -607,17 +607,11 @@ if (!("console" in window) || !("firebug" in console))
  * @example fireEvent($('my-input', 'click'));
  */
 function fireEvent(element, event) {
-    if (document.createEvent) {
-        // dispatch for all browsers except IE before version 9
-        var evt = document.createEvent('HTMLEvents');
+    // dispatch event
+    var evt = document.createEvent('HTMLEvents');
 
-        evt.initEvent(event, true, true); // event type, bubbling, cancelable
-        return element.dispatchEvent(evt);
-    }
-    // dispatch for IE before version 9
-    var evt = document.createEventObject();
-
-    return element.fireEvent('on' + event, evt);
+    evt.initEvent(event, true, true); // event type, bubbling, cancelable
+    return element.dispatchEvent(evt);
 
 }