Skip to content

Commit 36395ef

Browse files
author
Graham Wharton
committed
Resolved test failures
1 parent abf66b8 commit 36395ef

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

app/code/Magento/Email/Model/AbstractTemplate.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,8 @@ public function __construct(
215215
$this->templateFactory = $templateFactory;
216216
$this->filterManager = $filterManager;
217217
$this->urlModel = $urlModel;
218-
$this->fileStorageDatabase = $fileStorageDatabase ?: \Magento\Framework\App\ObjectManager::getInstance()->get(Database::class);
218+
$this->fileStorageDatabase = $fileStorageDatabase ?:
219+
\Magento\Framework\App\ObjectManager::getInstance()->get(Database::class);
219220
parent::__construct($context, $registry, null, null, $data);
220221
}
221222

app/code/Magento/Email/Test/Unit/Model/BackendTemplateTest.php

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,11 @@ class BackendTemplateTest extends \PHPUnit\Framework\TestCase
4848
*/
4949
private $serializerMock;
5050

51+
/**
52+
* @var \Magento\MediaStorage\Helper\File\Storage\Database|\PHPUnit_Framework_MockObject_MockObject
53+
*/
54+
private $databaseHelperMock;
55+
5156
protected function setUp()
5257
{
5358
$helper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
@@ -58,14 +63,25 @@ protected function setUp()
5863
$this->structureMock = $this->createMock(\Magento\Config\Model\Config\Structure::class);
5964
$this->structureMock->expects($this->any())->method('getFieldPathsByAttribute')->willReturn(['path' => 'test']);
6065

66+
$this->databaseHelperMock = $this->createMock(\Magento\MediaStorage\Helper\File\Storage\Database::class);
6167
$this->resourceModelMock = $this->createMock(\Magento\Email\Model\ResourceModel\Template::class);
6268
$this->resourceModelMock->expects($this->any())->method('getSystemConfigByPathsAndTemplateId')->willReturn(['test_config' => 2015]);
6369
/** @var ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject $objectManagerMock*/
6470
$objectManagerMock = $this->createMock(\Magento\Framework\ObjectManagerInterface::class);
6571
$objectManagerMock->expects($this->any())
6672
->method('get')
67-
->with(\Magento\Email\Model\ResourceModel\Template::class)
68-
->will($this->returnValue($this->resourceModelMock));
73+
->willReturnCallback(
74+
function ($value) {
75+
switch($value) {
76+
case \Magento\MediaStorage\Helper\File\Storage\Database::class:
77+
return ($this->databaseHelperMock);
78+
case \Magento\Email\Model\ResourceModel\Template::class:
79+
return ($this->resourceModelMock);
80+
default:
81+
return(NULL);
82+
}
83+
}
84+
);
6985

7086
\Magento\Framework\App\ObjectManager::setInstance($objectManagerMock);
7187

app/code/Magento/Email/composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
"magento/module-cms": "102.0.*",
1010
"magento/module-backend": "100.2.*",
1111
"magento/module-variable": "100.2.*",
12+
"magento/module-media-storage": "100.2.*",
1213
"magento/framework": "101.0.*"
1314
},
1415
"suggest": {

0 commit comments

Comments
 (0)