ENGCOM-3691: [Backport] Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero [REST API] #19612

magento-engcom-team · magento-engcom-team · commit 19d849b6baf1 · 2019-01-28T15:07:23.000-06:00
- Merge Pull Request #19612 from SikailoISM/magento2:wrong-attribute-option - Merged commits: 1. 14aa091
diff --git a/app/code/Magento/Catalog/Model/Product/Attribute/OptionManagement.php b/app/code/Magento/Catalog/Model/Product/Attribute/OptionManagement.php
@@ -47,7 +47,7 @@ public function add($attributeCode, $option)
                 /** @var \Magento\Eav\Api\Data\AttributeOptionInterface $attributeOption */
                     $attributeOption = $attributeOption->getLabel();
             });
-            if (in_array($option->getLabel(), $currentOptions)) {
+            if (in_array($option->getLabel(), $currentOptions, true)) {
                 return false;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function add($attributeCode, $option)`
`47`	`47`	`/** @var \Magento\Eav\Api\Data\AttributeOptionInterface $attributeOption */`
`48`	`48`	`$attributeOption = $attributeOption->getLabel();`
`49`	`49`	`});`
`50`		`- if (in_array($option->getLabel(), $currentOptions)) {`
	`50`	`+ if (in_array($option->getLabel(), $currentOptions, true)) {`
`51`	`51`	`return false;`
`52`	`52`	`}`
`53`	`53`	`}`