Skip to content

Commit 0901682

Browse files
author
Stanislav Idolov
committed
magento-engcom/magento2ce#2308: Code style fixes
1 parent 13c1f7d commit 0901682

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

app/code/Magento/PageCache/view/frontend/web/js/page-cache.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ define([
4242
* @param {jQuery} element - Comment holder
4343
*/
4444
(function lookup(element) {
45-
var iframeHostName;
45+
var iframeHostName,
46+
contents,
47+
elementContents;
4648

4749
// prevent cross origin iframe content reading
4850
if ($(element).prop('tagName') === 'IFRAME') {
@@ -54,11 +56,17 @@ define([
5456
}
5557
}
5658

57-
// rewrite jQuery contents()
58-
var contents = function (element) {
59-
return $.map(element, function (elem) {
59+
/**
60+
* Rewrite jQuery contents method
61+
*
62+
* @param {Object} el
63+
* @returns {Object}
64+
* @private
65+
*/
66+
contents = function (el) {
67+
return $.map(el, function (elem) {
6068
try {
61-
return $.nodeName(elem, "iframe") ?
69+
return $.nodeName(elem, 'iframe') ?
6270
elem.contentDocument || (elem.contentWindow ? elem.contentWindow.document : []) :
6371
$.merge([], elem.childNodes);
6472
} catch (e) {
@@ -68,7 +76,7 @@ define([
6876
});
6977
};
7078

71-
var elementContents = contents($(element));
79+
elementContents = contents($(element));
7280

7381
$.each(elementContents, function (index, el) {
7482
switch (el.nodeType) {

app/code/Magento/Swatches/view/adminhtml/web/js/product-attributes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ define([
439439

440440
activePanel.find('table input')
441441
.each(function () {
442-
if ($(this).is(':radio') && !$(this).prop("checked")) {
442+
if ($(this).is(':radio') && !$(this).prop('checked')) {
443443
return;
444444
}
445445
swatchValues.push(this.name + '=' + $(this).val());

0 commit comments

Comments
 (0)