Mqe 2270 #786
Merged
Mqe 2270 #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumyau
reviewed
Aug 18, 2020
| } | ||
|
|
||
| if ($pauseOnFail) { | ||
| print(PHP_EOL . PHP_EOL . "Failure encountered. Pausing execution..." . PHP_EOL . PHP_EOL . PHP_EOL); |
There was a problem hiding this comment.
Message looks good, may be too spaced out due to PHP_EOLs. I added both formats below, prefer the second one. See if you want to change it to the 2nd format.
[assertLoggedIn] AssertAdminSuccessLoginActionGroup
[waitForAdminAccountTextVisible] wait for element visible ".page-header .admin-user-account-text",30
Failure encountered. Pausing execution...
Execution PAUSED, starting interactive shell...
Instead
[assertLoggedIn] AssertAdminSuccessLoginActionGroup
[waitForAdminAccountTextVisible] wait for element visible ".page-header .admin-user-account-text",30
Failure encountered. Pausing execution...
Execution PAUSED, starting interactive shell...
There was a problem hiding this comment.
Ok, I will revert this change
There was a problem hiding this comment.
Reverted. I actually prefer the former.
soumyau
suggested changes
Aug 18, 2020
soumyau
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Contribution checklist