MQE-2212: Fix invalid behaviour MAGENTO_BACKEND_BASE_URL #780

soumyau · 2020-07-31T17:37:30Z

Description

Ported changes from #547 to develop

Fixed Issues (if relevant)

magento/magento2-functional-testing-framework#<issue_number>: Issue title
...

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/verification tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)
Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

coveralls · 2020-07-31T18:15:21Z

Coverage increased (+0.01%) to 61.332% when pulling cf94261 on MQE-2212 into 20af7fd on develop.

jilu1 · 2020-08-03T21:36:24Z

src/Magento/FunctionalTestingFramework/Provider/UrlProvider.php

 */
-class MftfGlobals
+class UrlProvider


This class is a util class that manipulates on the env vars. Let us not move it to top level directory structure.

This class is mean to provide some global constants that can be reused across entire framewrok. Not necessary only for urls. I would rather keep it the same name.

I think the reason why UrlProvider is used is to follow the same design pattern as Magento. Refer to UrlProvider class in Magento. Not a bad idea to have Url builder class separated out from Global constants. But let me know if you still think if this needs to be refactored to the original.

Which UrlProvider class you refers to? The Provider on root level file structure feels misleading.

Moved UrlProvider to Util folder, as per discussion

jilu1 · 2020-08-03T21:47:52Z

src/Magento/FunctionalTestingFramework/Provider/UrlProvider.php

+                    );
+            }
+            return UrlFormatter::format($baseUrl, $withTrailingSeparator);
+        } catch (TestFrameworkException $e) {
        }


Let's keep the logic of caching the $baseUrl and $backendBaseUrl. I remember adding this to fix performance deterioration.

$baseUrl changes based on $customArea specified in AdminFormExecutor and FrontendFormExecutor. Caching resulted in failures. How much of a degradation did you see?

Do you have a build after the change? I remember there were degradation when I make these files change, but I don't remember exactly if it's due to code here.

Had linked it in the ticket - https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/34863/

I added file level caching for AdminFormExecutor and FrontEndFormExecutor. Will retrigger build after changes look good.

2.4-develop: https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/35087/
MQE-2212: https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/35088/

jilu1 · 2020-08-03T21:49:27Z

src/Magento/FunctionalTestingFramework/Provider/UrlProvider.php

+        if ($backendBaseUrl) {
+            $backendBaseUrl = UrlFormatter::format($backendBaseUrl, $withTrailingSeparator);
+        }
+        return $backendBaseUrl;
    }


Do we still need this function? I mean will this be the same as getBaseUrl('admin')?

getBaseUrl('admin') calls this function in the switch case.

Does it need to be public? I mean if the entry point is getBaseUrl('admin')? It seems redundant.

good catch, changed it to private

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

jilu1

The Provider directory is unnecessary. What other providers you expected to belong here?
The baseUrl and adminBaseUrl are two global constants that will not change during test. I don't think we should change to calculate them every time based on area. Let's keep the original ideas to keep them cached as private static variables and accessible through getter functions of getBaseUrl() and getBackendBaseUrl() across entire framework. No need to store them separately in AdminFormExectuor, FrontendFormExecutor and WebApi Executor related classes. The changes should be much simplified. Let me know if you need more details.

soumyau · 2020-08-10T18:11:36Z

The Provider directory is unnecessary. What other providers you expected to belong here?

The baseUrl and adminBaseUrl are two global constants that will not change during test. I don't think we should change to calculate them every time based on area. Let's keep the original ideas to keep them cached as private static variables and accessible through getter functions of getBaseUrl() and getBackendBaseUrl() across entire framework. No need to store them separately in AdminFormExectuor, FrontendFormExecutor and WebApi Executor related classes. The changes should be much simplified. Let me know if you need more details.

Thanks for the comments, AC of this ticket was to port #547 in 3.0. If the AC is not acceptable, it's best to create a new ticket and plan it. What you think?

soumyau · 2020-08-11T03:44:15Z

The Provider directory is unnecessary. What other providers you expected to belong here?

The baseUrl and adminBaseUrl are two global constants that will not change during test. I don't think we should change to calculate them every time based on area. Let's keep the original ideas to keep them cached as private static variables and accessible through getter functions of getBaseUrl() and getBackendBaseUrl() across entire framework. No need to store them separately in AdminFormExectuor, FrontendFormExecutor and WebApi Executor related classes. The changes should be much simplified. Let me know if you need more details.

I think I understood what you meant by simpilifying url generation. Updated to code to only pull in relevant pieces from Lukasz's PR just enough to fix the problem.

Build: https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/35136/

jilu1 · 2020-08-11T16:17:23Z

Changes are simplified and Look good. Make sure to run UR build before merge.

soumyau · 2020-08-11T19:51:15Z

Changes are simplified and Look good. Make sure to run UR build before merge.

Build looks good - https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/35159/

soumyau force-pushed the MQE-2212 branch 2 times, most recently from f395707 to 7abcefe Compare July 31, 2020 21:57

MQE-2212: Fix invalid behaviour of MAGENTO_BACKEND_BASE_URL

71770cb

soumyau force-pushed the MQE-2212 branch from 7abcefe to 71770cb Compare July 31, 2020 22:19

jilu1 suggested changes Aug 4, 2020

View reviewed changes

jilu1 reviewed Aug 4, 2020

View reviewed changes

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php Show resolved Hide resolved

soumyau force-pushed the MQE-2212 branch 3 times, most recently from 117006e to 17898ad Compare August 6, 2020 18:19

MQE-2212: Fix invalid behaviour MAGENTO_BACKEND_BASE_URL

1fa50cf

soumyau force-pushed the MQE-2212 branch from 17898ad to 1fa50cf Compare August 7, 2020 20:19

Merge remote-tracking branch 'origin/develop' into MQE-2212

c5b47d7

jilu1 suggested changes Aug 10, 2020

View reviewed changes

MQE-2212: Fix invalid behaviour MAGENTO_BACKEND_BASE_URL

044341a

Merge branch 'develop' into MQE-2212

cf94261

jilu1 approved these changes Aug 11, 2020

View reviewed changes

soumyau merged commit 85d4fa6 into develop Aug 11, 2020

tomreece deleted the MQE-2212 branch August 19, 2020 20:37

MQE-2212: Fix invalid behaviour MAGENTO_BACKEND_BASE_URL #780

MQE-2212: Fix invalid behaviour MAGENTO_BACKEND_BASE_URL #780

Uh oh!

Conversation

soumyau commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixed Issues (if relevant)

Contribution checklist

Uh oh!

coveralls commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soumyau Aug 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jilu1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soumyau commented Aug 10, 2020

Uh oh!

soumyau commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jilu1 commented Aug 11, 2020

Uh oh!

soumyau commented Aug 11, 2020

Uh oh!

Uh oh!

soumyau commented Jul 31, 2020 •

edited

Loading

coveralls commented Jul 31, 2020 •

edited

Loading

soumyau Aug 6, 2020 •

edited

Loading

jilu1 left a comment •

edited

Loading

soumyau commented Aug 11, 2020 •

edited

Loading