Skip to content

[master] MQE-2231: Adobe open source repository standards compliance #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Jul 28, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@jilu1 jilu1 requested a review from dobooth July 28, 2020 18:35
tomreece
tomreece previously approved these changes Jul 28, 2020
@coveralls
Copy link

coveralls commented Jul 28, 2020

Coverage Status

Coverage remained the same at 55.85% when pulling e3b5ca2 on MQE-2231-master into f140fb5 on master.

@@ -152,6 +160,7 @@ Label| Description
**bugfix**| The issue or pull request is about fixing a bug.
**enhancement**| The issue or pull request that makes the MFTF even more awesome (for example new features, optimization, refactoring, etc).


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line can be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jilu1 jilu1 merged commit 91af47d into master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants