Skip to content

MQE-2216: Annual Docs Review Part 3 #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2020
Merged

MQE-2216: Annual Docs Review Part 3 #761

merged 4 commits into from
Jul 21, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Jul 16, 2020

Updated documentation based on 3.0.0 functionality.

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@soumyau
MQE-2216: Part 3 Docs Annual Review
9cc9530 
Updated documentation based on 3.0.0 functionality.
@soumyau soumyau changed the title MQE-2216 MQE-2216: Annual Docs Review Part 3 Jul 16, 2020
@coveralls
Copy link

coveralls commented Jul 16, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.85% when pulling 7c393e0 on MQE-2213-2216 into 9c8ab08 on annual-docs.

@dobooth dobooth added the DOC label Jul 16, 2020
@soumyau soumyau changed the base branch from master to annual-docs July 16, 2020 20:20
jilu1
jilu1 suggested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments inlined.

soumyau
soumyau commented Jul 21, 2020
View reviewed changes
Copy link
Contributor Author

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed review comments.

jilu1
jilu1 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@soumyau soumyau merged commit ddf5564 into annual-docs Jul 21, 2020
@tomreece tomreece deleted the MQE-2213-2216 branch July 27, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

@dobooth dobooth dobooth approved these changes

Assignees
No one assigned
Labels
DOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumyau @coveralls @jilu1 @dobooth