Skip to content

MQE-1902: Running bin/magento from MagentoWebDriver causing timeout i… #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 4, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Dec 3, 2019

…ssues on pipeline

Updated shellExecMagentoCLI to mimic command.php
Excluding cron from shell execution to prevent timeouts in pipeline. MTS ticket raised to investigate this issue: MTS-783

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

…ssues on pipeline

Updated shellExecMagentoCLI to mimic command.php
Excluding cron from shell execution to prevent timeouts in pipeline.
@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage increased (+1.4%) to 53.421% when pulling fa8e51b on MQE-1902-2 into 94737d1 on develop.

…ssues on pipeline

Not fetching output from cron.
…ssues on pipeline

Reverted changes, build still hangs with starting cron process from shell.
…ssues on pipeline

Reverted changes, build still hangs with starting cron process from shell.
…ssues on pipeline

reverting changes of community PR#343
…ssues on pipeline

reverting changes of community PR#343
…ssues on pipeline

removing unused references
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I double checked that the function roughly matches what is in master, and that generation is still good with the modified signature.

@KevinBKozan
Copy link
Contributor

After build is done, we can merge this.

@soumyau soumyau merged commit 580d6dc into develop Dec 4, 2019
@soumyau soumyau deleted the MQE-1902-2 branch April 30, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants