Skip to content

MQE-1644: Add ability to see JS log in Allure #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 23, 2019
Merged

MQE-1644: Add ability to see JS log in Allure #489

merged 8 commits into from
Oct 23, 2019

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Refactored ErrorLogger (no longer singleton, renamed for its actual use
  • Added stepAfter actions to log browser logs

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

KevinBKozan and others added 6 commits October 16, 2019 14:08
@KevinBKozan
MQE-1644: Add ability to see JS log in Allure
36a243a 
- Initial logging addition.
@KevinBKozan
MQE-1644: Add ability to see JS log in Allure
997a9ef 
- Addec blacklist
- Renamed variables
@KevinBKozan
MQE-1644: Add ability to see JS log in Allure
dc0bf75 
- Refactor ErrorLogger into BrowserLogUtil, no longer a singleton
@KevinBKozan
MQE-1644: Add ability to see JS log in Allure
31073a3 
- Unit test + static check fixes
@KevinBKozan
MQE-1644: Add ability to see JS log in Allure
d7d14c3 
- Added documentation
@KevinBKozan
Merge branch 'develop' into MQE-1644
2b8710b
@coveralls
Copy link

coveralls commented Oct 17, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.2%) to 53.612% when pulling ac6daba on MQE-1644 into e175381 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 53.802% when pulling 2b8710b on MQE-1644 into acf280b on develop.

jilu1
jilu1 suggested changes Oct 21, 2019
View reviewed changes
@KevinBKozan KevinBKozan merged commit c3f7c05 into develop Oct 23, 2019
@KevinBKozan KevinBKozan deleted the MQE-1644 branch October 23, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @jilu1