Skip to content

[Documentation] MQE-1796: Magento Git vs Composer and MFTF #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 24, 2019
Merged

[Documentation] MQE-1796: Magento Git vs Composer and MFTF #488

merged 7 commits into from
Oct 24, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Oct 17, 2019

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@soumyau soumyau changed the title MQE-1796: Magento Git vs Composer and MFTF [Documentation] MQE-1796: Magento Git vs Composer and MFTF Oct 17, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 53.378% when pulling af9f30b on MQE-1796 into 8ac2937 on develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 53.378% when pulling af9f30b on MQE-1796 into 8ac2937 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 53.378% when pulling af9f30b on MQE-1796 into 8ac2937 on develop.

@coveralls
Copy link

coveralls commented Oct 17, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 53.11% when pulling 2789a15 on MQE-1796 into fbc2d96 on master.

jilu1
jilu1 reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some rewording suggested.

docs/guides/git-vs-composer-install.md Outdated

Install guide: [GitHub Installation](https://devdocs.magento.com/mftf/docs/getting-started.html)

###How to download Magento + MFTF via Composer?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably makes more sense to remove MFTF here, what do you think? Since MFTF cannot be installed by Composer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to something more generic.

@okolesnyk okolesnyk closed this Oct 18, 2019
@okolesnyk okolesnyk reopened this Oct 18, 2019
soumyau
soumyau commented Oct 18, 2019
View reviewed changes
Copy link
Contributor Author

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed review comments

docs/guides/git-vs-composer-install.md Outdated

Install guide: [GitHub Installation](https://devdocs.magento.com/mftf/docs/getting-started.html)

###How to download Magento + MFTF via Composer?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to something more generic.

@jilu1 jilu1 self-requested a review October 18, 2019 16:32
jilu1
jilu1 previously approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@soumyau soumyau changed the base branch from develop to master October 18, 2019 18:45
KevinBKozan
KevinBKozan suggested changes Oct 21, 2019
View reviewed changes
@KevinBKozan KevinBKozan requested a review from dobooth October 21, 2019 15:10
soumyau
soumyau commented Oct 22, 2019
View reviewed changes
Copy link
Contributor Author

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as per review comments.

KevinBKozan
KevinBKozan previously approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just need @dobooth review

@dobooth dobooth added the DOC label Oct 24, 2019
@KevinBKozan KevinBKozan merged commit 2df6ebf into master Oct 24, 2019
@dobooth dobooth deleted the MQE-1796 branch October 29, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobooth dobooth dobooth approved these changes

@jilu1 jilu1 jilu1 left review comments

@KevinBKozan KevinBKozan KevinBKozan left review comments

Assignees
No one assigned
Labels
DOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@soumyau @coveralls @jilu1 @KevinBKozan @dobooth @okolesnyk