-
Notifications
You must be signed in to change notification settings - Fork 132
MQE-610: [PHPMD] Reduce Cyclomatic Complexity in Problem Methods #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
Refactored to keep Cyclomatic complexity <= 10. Added comments to below files to refactor later ** Config/FileResolver/Module.php ** Config/Converter.php ** Config/Dom.php
fixing unit tests
Refactored to keep Cyclomatic complexity <= 10. Added comments to functions that are not refactored for readability
Fixed unit tests
modularized SuiteObjectExtractor.php
updated with develop made changes to comments of SuiteObjectExtractor.php
fixed unit tests
fixed unit tests
jilu1
reviewed
Sep 25, 2019
src/Magento/FunctionalTestingFramework/ObjectManager/Config/Config.php
Outdated
Show resolved
Hide resolved
jilu1
reviewed
Sep 25, 2019
src/Magento/FunctionalTestingFramework/ObjectManager/Config/Mapper/Dom.php
Outdated
Show resolved
Hide resolved
jilu1
suggested changes
Sep 26, 2019
src/Magento/FunctionalTestingFramework/ObjectManager/Config/Mapper/Dom.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Objects/EntityDataObject.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Config/FileResolver/Module.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Persist/OperationDataArrayResolver.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Persist/OperationDataArrayResolver.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/StaticCheck/TestDependencyCheck.php
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/StaticCheck/TestDependencyCheck.php
Outdated
Show resolved
Hide resolved
fixed as per review comments
soumyau
commented
Sep 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed as per review comments.
src/Magento/FunctionalTestingFramework/Config/FileResolver/Module.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Objects/EntityDataObject.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Persist/OperationDataArrayResolver.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Persist/OperationDataArrayResolver.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/ObjectManager/Config/Mapper/Dom.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/ObjectManager/Config/Mapper/Dom.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/StaticCheck/TestDependencyCheck.php
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/StaticCheck/TestDependencyCheck.php
Outdated
Show resolved
Hide resolved
jilu1
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks good, please run builds to double check.
src/Magento/FunctionalTestingFramework/StaticCheck/TestDependencyCheck.php
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored to keep Cyclomatic complexity <= 10.
Added comments to below files to refactor later
** Config/FileResolver/Module.php
** Config/Converter.php
** Config/Dom.php
Description
Fixed Issues (if relevant)
Contribution checklist