Skip to content

MQE-610: [PHPMD] Reduce Cyclomatic Complexity in Problem Methods #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 30, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Sep 20, 2019

Refactored to keep Cyclomatic complexity <= 10.
Added comments to below files to refactor later
** Config/FileResolver/Module.php
** Config/Converter.php
** Config/Dom.php

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 53.578% when pulling cc7a6a7 on MQE-610 into e850699 on develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 53.578% when pulling cc7a6a7 on MQE-610 into e850699 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 53.578% when pulling cc7a6a7 on MQE-610 into e850699 on develop.

@coveralls
Copy link

coveralls commented Sep 20, 2019

Coverage Status

Coverage decreased (-1.5%) to 52.343% when pulling 01fb9fd on MQE-610 into 50ace76 on develop.

Refactored to keep Cyclomatic complexity <= 10.
Added comments to below files to refactor later
** Config/FileResolver/Module.php
** Config/Converter.php
** Config/Dom.php
@jilu1 jilu1 self-assigned this Sep 25, 2019
Copy link
Contributor Author

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed as per review comments.

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good, please run builds to double check.

@soumyau soumyau merged commit 02902f9 into develop Sep 30, 2019
@jilu1 jilu1 deleted the MQE-610 branch February 6, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants