MQE-1671: document using credentials with vault in MFTF tests #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilu1
commented
Sep 18, 2019
docs/credentials.md
Outdated
| @@ -5,12 +5,12 @@ use the MFTF credentials feature to hide sensitive [data][] like integration tok | |||
|
|
|||
| Currently MFTF supports two types of credential storage: **.credentials file** and **HashiCorp vault**. | |||
|
|
|||
| # Configure File Storage | |||
| #3 Configure File Storage | |||
jilu1
commented
Sep 18, 2019
docs/credentials.md
Outdated
|
|
||
| The MFTF creates a sample file for credentials during [initial setup][]: `magento2/dev/tests/acceptance/.credentials.example`. | ||
| The file contains an example list of keys for fields that can require credentials. | ||
|
|
||
| ### Create `.credentials` | ||
| ## Create `.credentials` |
There was a problem hiding this comment.
The headings are not accurate. For example, "Configure File Storage" should be one level higher than "Create .credentials", etc
jilu1
commented
Sep 18, 2019
docs/credentials.md
Outdated
| @@ -22,7 +22,7 @@ cd dev/tests/acceptance/ | |||
| cp .credentials.example .credentials | |||
| ``` | |||
|
|
|||
| ### Add `.credentials` to `.gitignore` | |||
| ## Add `.credentials` to `.gitignore` | |||
There was a problem hiding this comment.
Same here, and the rest of the headings
dobooth
previously approved these changes
Sep 18, 2019
dobooth
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Contribution checklist