MQE-1755: mftf run:test Test1 Test2 does not run before/after hooks c… #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly fixed unit tests
…orrectly fix unit tests
KevinBKozan
suggested changes
Sep 11, 2019
| //for tests in suites, run them as a group to run before and after block | ||
| foreach (array_keys($suitesConfig) as $suite) { | ||
| $fullCommand = $codeceptionCommand . " -g {$suite}"; | ||
| $process = new Process($fullCommand); |
There was a problem hiding this comment.
Ln 152 - 158 are duplicates of 126-132. Abstract it out into its own function so that you can just call something like
$subreturnCode = $this->executeTestCommand($fullCommand);
$this->returnCode = max($this->returnCode, $subreturnCode);
Double check for any more duped variable assignments/etc for consolidation as well.
There was a problem hiding this comment.
created a new function executeTestCommand that runs the codecept command.
…orrectly fixed unit test failures
KevinBKozan
approved these changes
Sep 13, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Feb 26, 2025
MFTF 5.0.3 Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…orrectly
Description
Fixed Issues (if relevant)
Contribution checklist