MQE-1703: Implicit Suite Generation for Tests #434
Conversation
fixing unit tests
fixing unit tests
fixing unit tests
fixing unit tests
fixing unit tests
fixing unit tests
fixing bug with test generation
| @@ -104,4 +111,27 @@ function ($type, $buffer) use ($output) { | |||
| } | |||
| return $returnCode; | |||
| } | |||
|
|
|||
| /** Get an array of tests with resolved suite references from $testConfiguration | |||
There was a problem hiding this comment.
Top of docblock needs empty line
| ); | ||
| } | ||
| // configuration for tests | ||
| else $testConfiguration['tests'][] = $test; |
There was a problem hiding this comment.
Need to use multiline else formatting:
} else {
$testConfiguration['tests'][] = $test;
}
| $testConfiguration['tests'] = null; | ||
| $testConfiguration['suites'] = null; | ||
| $testsReferencedInSuites = SuiteObjectHandler::getInstance()->getAllTestReferences(); | ||
| $resolvedTests = []; |
There was a problem hiding this comment.
Very minor but rename this to $suiteToTestPair, I thought at first this would hold either type of test but it only holds suite:test pairs
| foreach($tests as $test) { | ||
| if (array_key_exists($test, $testsReferencedInSuites)) { | ||
| $suites = $testsReferencedInSuites[$test]; | ||
| $resolvedTests = array_merge( |
There was a problem hiding this comment.
Can we change this array_merge/map combo to something a little more simple?
foreach ($suites as $suite) {
$resolvedTests[] = "$suite:$test";
}
array_map/merge are both recursive loops at the language level (at least I know map is) so this alternative is either equal or actually faster (easier to read in either case)
There was a problem hiding this comment.
was trying to avoid nested loops as I didn't find many implementations of it in code, thought it was a style thing. Changed it.
| $testArrayBuilder = []; | ||
|
|
||
| foreach ($suitesArray as $suite => $tests) { | ||
| $testArrayBuilder = array_merge( |
There was a problem hiding this comment.
See commend in BaseGenerateCommand, this can probably be simplified into one foreach
Style fixes
style fixes
| $testConfiguration['tests'] = null; | ||
| $testConfiguration['suites'] = null; | ||
| $testsReferencedInSuites = SuiteObjectHandler::getInstance()->getAllTestReferences(); | ||
| $resolvedTests = []; |
| @@ -104,4 +111,27 @@ function ($type, $buffer) use ($output) { | |||
| } | |||
| return $returnCode; | |||
| } | |||
|
|
|||
| /** Get an array of tests with resolved suite references from $testConfiguration | |||
| $testArrayBuilder = []; | ||
|
|
||
| foreach ($suitesArray as $suite => $tests) { | ||
| $testArrayBuilder = array_merge( |
| foreach($tests as $test) { | ||
| if (array_key_exists($test, $testsReferencedInSuites)) { | ||
| $suites = $testsReferencedInSuites[$test]; | ||
| $resolvedTests = array_merge( |
There was a problem hiding this comment.
was trying to avoid nested loops as I didn't find many implementations of it in code, thought it was a style thing. Changed it.
Description
Fixed Issues (if relevant)
Contribution checklist