Skip to content

MQE-1636: [GENERATOR] Page Source Actions are not quoted properly #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2019
Merged

MQE-1636: [GENERATOR] Page Source Actions are not quoted properly #394

merged 2 commits into from
Jul 26, 2019

Conversation

tomreece
Copy link
Contributor

Description

https://jira.corp.magento.com/browse/MQE-1636

This PR fixes and verifies that the html attribute works correctly for these actions:

  • seeInPageSource
  • dontSeeInPageSource
  • seeInSource
  • dontSeeInSource

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Jul 25, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.6%) to 54.524% when pulling f473287 on MQE-1636 into 95b1eec on develop.

@KevinBKozan KevinBKozan self-requested a review July 26, 2019 15:35
KevinBKozan
KevinBKozan approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no errors found in QAing.

@KevinBKozan KevinBKozan merged commit 5c7bea5 into develop Jul 26, 2019
@KevinBKozan KevinBKozan deleted the MQE-1636 branch July 26, 2019 19:18
magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 2, 2024
@KevinBKozan
Merge pull request #394 from magento-commerce/MFTF4.7.2-Release
352d35f 
MFTF4.7.2 : Release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomreece @coveralls @KevinBKozan