Skip to content

MQE-1597 #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2019
Merged

MQE-1597 #372

merged 1 commit into from
Jun 26, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Jun 21, 2019

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Jun 21, 2019

Coverage Status

Coverage decreased (-1.6%) to 54.622% when pulling 94d0c15 on MQE-1597 into 2a0b811 on develop.

@KevinBKozan
Copy link
Contributor

@soumyau how did you go about generating this .lock file? I'm seeing a lot more dependency differences than I would expect. In theory the process would be

  • php7.0
  • composer remove epfremme/swagger-php
  • add in suggest block manually

When doing this I get a changeset that is more around ~250 lines and very few dependency changes

…/twofactorauth

updated composer.json and .lock to fix packaging issues
@soumyau soumyau reopened this Jun 24, 2019
@soumyau soumyau requested a review from KevinBKozan June 24, 2019 18:19
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked changes against 2.2/2.3, and ensured package conflict doesn't exist anymore. Good to merge!

@soumyau soumyau merged commit 2a723c0 into develop Jun 26, 2019
@jilu1 jilu1 deleted the MQE-1597 branch February 6, 2020 16:54
magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants