MQE-1427 - Support _CREDS in <magentoCLI> action and in Data #368

ivy00johns · 2019-06-13T14:21:45Z

Description

Adding support for _CREDS to the <magentoCLI> and <createData> actions.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/verification tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)
Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

- Adding new logic to support _CREDS in magentoCLI, createData and updateData.

- Removing "updateData", does NOT contain a <field>.

- Correcting the magentoCLI action when secret data is present. - Adding support for createData when secret data is present.

coveralls · 2019-06-13T14:30:57Z

Coverage decreased (-1.5%) to 54.441% when pulling 5fc6347 on MQE-1427 into 41caa75 on develop.

coveralls · 2019-06-13T14:30:58Z

Coverage decreased (-0.1%) to 54.534% when pulling c5286e6 on MQE-1427 into 4d55d3f on develop.

ivy00johns · 2019-06-14T13:48:10Z

Working on the Travis CI build issues now.

- Adding a missing annotation to a doc block. - Adjusting line lengths. - Replaced array with short array.

KevinBKozan

Overall idea and design is in the right direction, just had a few thoughts about simplifying some of the code structure!

Also, please add new verification tests to test the secret field implementation (I don't think we have a test dedicated to secret actions, would be a good place to start one).

src/Magento/FunctionalTestingFramework/Test/Util/ActionMergeUtil.php

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

src/Magento/FunctionalTestingFramework/Test/Util/ActionMergeUtil.php

src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php

- Adjusting line lengths.

- Replacing getter functions with a variable.

- Removing duplicate function.

- Adding docblock description.

- Replacing my logic for decrypting the value with existing logic I was unaware of.

- Replacing my logic with a cleaner version.

- Correcting exception.

KevinBKozan

Two small things you forgot to include in your commits I believe.

Also, please create a new verification test to test all of the available secret actions

src/Magento/FunctionalTestingFramework/Test/Util/ActionMergeUtil.php

- Removing unused function.

- Adding const. - Referencing const values.

ivy00johns · 2019-06-17T16:01:16Z

Corrected Kevin's comments minus the Verification Test. Working on that now.

- Correcting a failing static test. Assert was not properly configured originally.

- Adding verification test.

- Correcting if logic for non-secret actions.

- Correcting static test.

- Correcting ActionMergeUtil so it doesn't use fillSecretField when the creds aren't present.

- Correcting an issue in the verification test.

- Updating verification test so it is compatible with the latest version of the Test Generator.

- Correcting verification test issues.

- Adding unit tests.

- Correcting line lengths for the Travis CI build.

src/Magento/FunctionalTestingFramework/Test/Util/ActionMergeUtil.php

src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php

- Correcting Travis CI issues regarding multi line functions.

- Correcting multiline function errors in Travis CI. - Updating the function signature for the CLI function to match the other CLI function casing. - Adding new function to properly decrypt CLI actions. - Adding MagentoCLISecret to the ActionMergeUtil.

- Correcting verification test issue due to casing.

- Correcting spacing issues.

- Correcting verification test issues.

KevinBKozan

2 Small changes, plus one change to PersistedObjectHandler.php:

In createEntity() you'll need to loop through them and use the new decryptAllSecretsInString() function.

src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/CredentialStore.php

src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php

- Correcting verification test issues around extra new lines. Removed the extra new lines.

- Adding missing parentheses.

- Adding missing return.

- Correcting an issue around null values in the PersistedObjectHandler.

ivy00johns · 2019-06-21T18:45:31Z

Changes submitted for the PersistedObjectHandler.

- Correcting verification tests by replacing null with [].

-Correcting final verification tests.

KevinBKozan

QA and CR complete, feature is good to go 👍

ACQE-5871: Add ability to increase default MagentoCLI timeout

ivy00johns added 3 commits June 11, 2019 15:30

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

66fb4c2

- Adding new logic to support _CREDS in magentoCLI, createData and updateData.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

55e6421

- Removing "updateData", does NOT contain a <field>.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

5fc6347

- Correcting the magentoCLI action when secret data is present. - Adding support for createData when secret data is present.

Merge branch 'develop' into MQE-1427

052e15d

ivy00johns added 2 commits June 14, 2019 08:54

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

d9060d7

- Adding a missing annotation to a doc block. - Adjusting line lengths. - Replaced array with short array.

Merge remote-tracking branch 'origin/MQE-1427' into MQE-1427

98480cf

KevinBKozan suggested changes Jun 14, 2019

View reviewed changes

ivy00johns and others added 9 commits June 14, 2019 09:21

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

6dcd2f4

- Adjusting line lengths.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

7b8de7e

- Replacing getter functions with a variable.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

acf87b6

- Removing duplicate function.

Merge branch 'develop' into MQE-1427

ecb5a8a

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

b0e821f

- Adding docblock description.

Merge remote-tracking branch 'origin/MQE-1427' into MQE-1427

bffe7d6

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

847e5ff

- Replacing my logic for decrypting the value with existing logic I was unaware of.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

eeb174a

- Replacing my logic with a cleaner version.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

352b660

- Correcting exception.

KevinBKozan suggested changes Jun 17, 2019

View reviewed changes

src/Magento/FunctionalTestingFramework/Test/Util/ActionMergeUtil.php Outdated Show resolved Hide resolved

src/Magento/FunctionalTestingFramework/Test/Util/ActionMergeUtil.php Outdated Show resolved Hide resolved

ivy00johns added 2 commits June 17, 2019 09:59

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

0eaaa01

- Removing unused function.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

f83c893

- Adding const. - Referencing const values.

ivy00johns and others added 7 commits June 18, 2019 09:15

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

2d5e178

- Correcting a failing static test. Assert was not properly configured originally.

Merge branch 'develop' into MQE-1427

7c837c3

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

7a1a4e5

- Adding verification test.

Merge remote-tracking branch 'origin/MQE-1427' into MQE-1427

e4ddde9

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

ad99e96

- Correcting if logic for non-secret actions.

Merge branch 'develop' into MQE-1427

0cd5a47

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

d1b3be3

- Correcting static test.

ivy00johns added 6 commits June 18, 2019 15:51

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

6cf6400

- Correcting ActionMergeUtil so it doesn't use fillSecretField when the creds aren't present.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

1e22a8c

- Correcting an issue in the verification test.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

fd66a0c

- Updating verification test so it is compatible with the latest version of the Test Generator.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

537b404

- Correcting verification test issues.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

82a80c6

- Adding unit tests.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

c38ab37

- Correcting line lengths for the Travis CI build.

KevinBKozan suggested changes Jun 20, 2019

View reviewed changes

ivy00johns added 5 commits June 20, 2019 13:23

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

a07275f

- Correcting Travis CI issues regarding multi line functions.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

29b37f4

- Correcting verification test issue due to casing.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

9f96927

- Correcting spacing issues.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

3d2d857

- Correcting verification test issues.

KevinBKozan suggested changes Jun 21, 2019

View reviewed changes

src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/CredentialStore.php Outdated Show resolved Hide resolved

src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php Outdated Show resolved Hide resolved

ivy00johns added 4 commits June 21, 2019 11:19

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

8cd1a39

- Correcting verification test issues around extra new lines. Removed the extra new lines.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

9ef7ea7

- Adding missing parentheses.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

637c3eb

- Adding missing return.

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

32fac0c

- Correcting an issue around null values in the PersistedObjectHandler.

ivy00johns added 2 commits June 21, 2019 15:47

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

cd0d237

- Correcting verification tests by replacing null with [].

MQE-1427: Support _CREDS in <magentoCLI> action and in Data

d103842

-Correcting final verification tests.

KevinBKozan approved these changes Jun 25, 2019

View reviewed changes

Merge branch 'develop' into MQE-1427

c5286e6

KevinBKozan merged commit 09f81b6 into develop Jun 28, 2019

KevinBKozan deleted the MQE-1427 branch July 26, 2019 19:18

magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 11, 2023

Merge pull request #368 from magento-commerce/ACQE-5871

f285fe3

ACQE-5871: Add ability to increase default MagentoCLI timeout

MQE-1427 - Support _CREDS in <magentoCLI> action and in Data #368

MQE-1427 - Support _CREDS in <magentoCLI> action and in Data #368

Uh oh!

Conversation

ivy00johns commented Jun 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contribution checklist

Uh oh!

coveralls commented Jun 13, 2019

Uh oh!

coveralls commented Jun 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivy00johns commented Jun 14, 2019

Uh oh!

KevinBKozan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KevinBKozan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ivy00johns commented Jun 17, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KevinBKozan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ivy00johns commented Jun 21, 2019

Uh oh!

KevinBKozan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ivy00johns commented Jun 13, 2019 •

edited

Loading

coveralls commented Jun 13, 2019 •

edited

Loading