Skip to content

MQE-1234 & MQE-659: StepKey in test result output and native XML comments #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 18, 2019

Conversation

okolesnyk
Copy link
Member

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@okolesnyk okolesnyk requested a review from KevinBKozan June 7, 2019 18:11
@coveralls
Copy link

coveralls commented Jun 7, 2019

Coverage Status

Coverage increased (+1.8%) to 56.211% when pulling bafc0c9 on MQE-1234-alex-edition into 3a77cc5 on develop.

Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a verification test to test out the XML unsafe characters usecase specifically (< > & " ' etc)

@okolesnyk okolesnyk changed the title MQE-1234: Allow XML Parser to read XML comment into comment action MQE-1234 & MQE-659: StepKey in test result output and native XML comments Jun 7, 2019
@okolesnyk okolesnyk dismissed KevinBKozan’s stale review June 7, 2019 20:28

Commit requested changes.

@okolesnyk okolesnyk requested a review from KevinBKozan June 7, 2019 20:28
@okolesnyk okolesnyk dismissed KevinBKozan’s stale review June 10, 2019 15:51

Commit latest fixes

@okolesnyk okolesnyk requested a review from KevinBKozan June 10, 2019 15:51
@KevinBKozan
Copy link
Contributor

KevinBKozan commented Jun 10, 2019

Found an issue with both of these contents combined:
Create a suite with the following block:

<before>
    <!--COMMENT HERE-->
    <magentoCLI stepKey="STEPKEY" command="helloworld"/>
</before>

Then debug at ln 176 of GroupClassGenerator, it splits lines based on ; which leads to:

$STEPKEY = $webDriver->magentoCLI("helloworld")
 // stepKey: STEPKEY$webDriver->comment($STEPKEY)

Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug, see above.

@okolesnyk okolesnyk requested a review from KevinBKozan June 12, 2019 21:50
@okolesnyk okolesnyk dismissed KevinBKozan’s stale review June 12, 2019 21:51

Eventually @KevinBKozan fixed the bug.

Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more bugs found, looks like this is good to go.

@KevinBKozan KevinBKozan merged commit 1dd7cd2 into develop Jun 18, 2019
@KevinBKozan KevinBKozan deleted the MQE-1234-alex-edition branch August 12, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants