-
Notifications
You must be signed in to change notification settings - Fork 132
MQE-1234 & MQE-659: StepKey in test result output and native XML comments #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nctional-testing-framework into MQE-1234-alex-edition
…nctional-testing-framework into MQE-1234-alex-edition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a verification test to test out the XML unsafe characters usecase specifically (< > & " '
etc)
src/Magento/FunctionalTestingFramework/Test/Config/Converter/Dom/Flat.php
Outdated
Show resolved
Hide resolved
dev/tests/verification/TestModule/ActionGroup/BasicActionGroup.xml
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Test/Util/ActionGroupObjectExtractor.php
Show resolved
Hide resolved
…unctional-testing-framework into MQE-1234-alex-edition
Found an issue with both of these contents combined:
Then debug at ln 176 of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bug, see above.
- bugfix + new verification tests
- do not humanize comment actions
Eventually @KevinBKozan fixed the bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more bugs found, looks like this is good to go.
Description
Fixed Issues (if relevant)
Contribution checklist