Skip to content

MQE-1541: Add option to generate:tests for XSD validation on 'merged files' #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 21, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented May 8, 2019

Description

https://jira.corp.magento.com/browse/MQE-1541

  • Added a --fastdebug (-a) option to generate:tests to run XSD validation against 'merged files'.
  • Introduce a new .env parameter 'MFTF_FAST_DEBUG' that can be used to enable/disable fast debugging
  • Logging xsd validation errors as CRITICAL in mftf log

5/16: Changes to the implementation as per recent discussions:
1. enable debugging for generate:tests by default
2. --debug runs developer mode allowing enhanced debugging
3. introduced input option 'ignore' to skip debugging for backward compatibility. To be removed in next MAJOR release

Fixed Issues (if relevant)

Fixed issue with mergedTestSchema error : Skipping pointless attribute use prohibition 'skipReadiness'

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented May 8, 2019

CLA assistant check
All committers have signed the CLA.

@soumyau soumyau requested review from KevinBKozan and jilu1 May 8, 2019 18:00
@soumyau soumyau requested a review from okolesnyk May 8, 2019 18:06
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes required to logger, but also have a bigger question around the new flag

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 56.241% when pulling f1f2381 on MQE-1541 into 9359af2 on develop.

@coveralls
Copy link

coveralls commented May 8, 2019

Coverage Status

Coverage increased (+1.3%) to 55.958% when pulling a3f25bd on MQE-1541 into 9359af2 on develop.

@KevinBKozan KevinBKozan changed the title Add option to generate:tests for XSD validation on 'merged files' MQE-1541: Add option to generate:tests for XSD validation on 'merged files' May 9, 2019
@soumyau
Copy link
Contributor Author

soumyau commented May 15, 2019

Some changes required to logger, but also have a bigger question around the new flag

Changed the implementation as per recent discussions:

  1. enabled debugging for generate:tests by default
  2. --debug runs developer mode allowing enhanced debugging
  3. introduced input option 'ignore' to skip debugging for backward compatibility

@soumyau soumyau requested a review from KevinBKozan May 15, 2019 17:00
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some changes as to how we are setting the mode, but conceptually it's good.
Also there's some skipReadiness changes that I don't think should be included in this PR.

@KevinBKozan
Copy link
Contributor

Spoke in person with @soumyau. Decision was as follows:

  • Keep --debug as optional
  • Map --debug to developer for backwards compatibility
  • Allow setting of debug level via --debug developer/production/default

Copy link
Contributor Author

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as per recent discussions

Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA finished, one small requirement but otherwise we should be good to go.

@KevinBKozan KevinBKozan merged commit 958e9c3 into develop May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants