-
Notifications
You must be signed in to change notification settings - Fork 132
MQE-1541: Add option to generate:tests for XSD validation on 'merged files' #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…files' fixed comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes required to logger, but also have a bigger question around the new flag
src/Magento/FunctionalTestingFramework/Util/Logger/MftfLogger.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Util/Logger/MftfLogger.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Config/Reader/Filesystem.php
Outdated
Show resolved
Hide resolved
…files' Updates for default debugging
Changed the implementation as per recent discussions:
|
…files' fxing code sniffer errors
…files' fixed code sniffer errors
…files' fixed static-check errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some changes as to how we are setting the mode
, but conceptually it's good.
Also there's some skipReadiness
changes that I don't think should be included in this PR.
src/Magento/FunctionalTestingFramework/Config/MftfApplicationConfig.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Console/GenerateTestsCommand.php
Outdated
Show resolved
Hide resolved
Spoke in person with @soumyau. Decision was as follows:
|
…files' Changes from review comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as per recent discussions
src/Magento/FunctionalTestingFramework/Config/MftfApplicationConfig.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Console/GenerateTestsCommand.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA finished, one small requirement but otherwise we should be good to go.
Description
https://jira.corp.magento.com/browse/MQE-1541
5/16: Changes to the implementation as per recent discussions:
1. enable debugging for generate:tests by default
2. --debug runs developer mode allowing enhanced debugging
3. introduced input option 'ignore' to skip debugging for backward compatibility. To be removed in next MAJOR release
Fixed Issues (if relevant)
Fixed issue with mergedTestSchema error :
Skipping pointless attribute use prohibition 'skipReadiness'
Contribution checklist