Skip to content

MQE-1439: Invalid XML character in AdminDateFormatOnAttributePageTest causes Allure report parse error #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2019
Merged

MQE-1439: Invalid XML character in AdminDateFormatOnAttributePageTest causes Allure report parse error #323

merged 4 commits into from
Apr 9, 2019

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Mar 27, 2019 •
edited
Loading

Description

  • Control characters break Allure report generation
  • This change strips control characters
  • When this is released, we can unskip MFTF testCaseId MAGETWO-96136
  • Here's a link to a build where this is fixed and MAGETWO-96136 is unskipped and ran

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

tomreece added 2 commits March 27, 2019 10:56
@tomreece
MQE-1439: Invalid XML character in AdminDateFormatOnAttributePageTest…
c0d491c 
… causes Allure report parse error
@tomreece
MQE-1439: Invalid XML character in AdminDateFormatOnAttributePageTest…
0dc417b 
… causes Allure report parse error

- Improve function comment
@coveralls
Copy link

coveralls commented Mar 28, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 56.991% when pulling 8c450b7 on MQE-1439 into 6d0cde4 on develop.

@tomreece tomreece merged commit c6697d9 into develop Apr 9, 2019
@tomreece tomreece deleted the MQE-1439 branch September 3, 2019 16:32
magento-devops-reposync-svc pushed a commit that referenced this pull request Aug 15, 2023
@okolesnyk
Merge pull request #323 from magento-commerce/suite-hotfix
0f30611 
Suite hotfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljcalandra aljcalandra aljcalandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomreece @coveralls @aljcalandra