Skip to content

MQE-1472: Action Group context in Tests and Allure #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2019
Merged

MQE-1472: Action Group context in Tests and Allure #319

merged 5 commits into from
Apr 9, 2019

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Added <comment> actions before and after actionGroups
  • Above commands are used in MagentoAllureAdapter to nest actionGroup actions for the allure report

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1472: Action Group context in Tests and Allure
79c2af9 
- Added Context comment in ActionGroupObject
- Allure now nests actionGroup steps a parent step
@KevinBKozan
MQE-1472: Action Group context in Tests and Allure
cd42bf6 
- ActionGroup StepKey added to index in steps, fixes duplicate AG collisions
@KevinBKozan
MQE-1472: Action Group context in Tests and Allure
de0b3fe 
- Static/Verification test fixes
@coveralls
Copy link

coveralls commented Mar 20, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.7%) to 56.991% when pulling e95df3f on MQE-1472 into ee5d3f7 on develop.

@KevinBKozan
MQE-1472: Action Group context in Tests and Allure
fedf28e 
- Removed unecessary intermediate Step object clone
@KevinBKozan KevinBKozan requested a review from aljcalandra April 9, 2019 15:29
@KevinBKozan KevinBKozan merged commit f8cf2c3 into develop Apr 9, 2019
@KevinBKozan KevinBKozan deleted the MQE-1472 branch April 9, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljcalandra aljcalandra aljcalandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @aljcalandra