Skip to content

MQE-1447: Remove notice on empty page module #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2019
Merged

MQE-1447: Remove notice on empty page module #309

merged 2 commits into from
Apr 5, 2019

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Added ternary null checing for page.xml attributes

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1447: Remove notice on empty page module
a5afd2b 
- Added ternary null checing for page.xml attributes
@coveralls
Copy link

coveralls commented Feb 14, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 56.853% when pulling e28d1c5 on MQE-1447 into 7f82e4d on develop.

@KevinBKozan KevinBKozan merged commit ee5d3f7 into develop Apr 5, 2019
@KevinBKozan KevinBKozan deleted the MQE-1447 branch April 5, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aljcalandra aljcalandra aljcalandra approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @aljcalandra