Skip to content

Update requirements to include php7.3 support #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Update requirements to include php7.3 support #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f98c8e2
Update requirements to include php7.3 support
pmclain Dec 28, 2018
9812c6b
Skip coverage check on php 7.3
pmclain Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ php:
- 7.0
- 7.1
- 7.2
- 7.3
install: composer install --no-interaction --prefer-source
env:
matrix:
Expand Down
4 changes: 3 additions & 1 deletion bin/phpunit-checks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ vendor/bin/phpunit --configuration dev/tests/phpunit.xml --testsuite unit --cove
echo "==============================="
echo " UNIT TEST COVERAGE"
echo "==============================="
vendor/bin/coverage-check clover.xml $UNIT_COVERAGE_THRESHOLD
if [[ ${TRAVIS_PHP_VERSION:0:3} != "7.3" ]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmclain I know it's been some time since this PR was created, but Xdebug 2.7.0 has since been released (with 7.3 support).
At this point, is this conditional skip still necessary?

then vendor/bin/coverage-check clover.xml $UNIT_COVERAGE_THRESHOLD
fi

echo "==============================="
echo " VERIFICATION TESTS"
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"sort-packages": true
},
"require": {
"php": "7.0.2|7.0.4|~7.0.6|~7.1.0|~7.2.0",
"php": "7.0.2||7.0.4||~7.0.6||~7.1.0||~7.2.0||~7.3.0",
"ext-curl": "*",
"allure-framework/allure-codeception": "~1.2.6",
"codeception/codeception": "~2.3.4",
Expand All @@ -25,7 +25,7 @@
"require-dev": {
"squizlabs/php_codesniffer": "~3.2",
"sebastian/phpcpd": "~3.0 || ~4.0",
"brainmaestro/composer-git-hooks": "^2.3",
"brainmaestro/composer-git-hooks": "^2.3.1",
"doctrine/cache": "<1.7.0",
"codeception/aspect-mock": "^3.0",
"goaop/framework": "2.2.0",
Expand Down
17 changes: 9 additions & 8 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.