MQE-1123: Impossible remove data created in preconditions from test steps #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored TestGenerator code to use new Handler - Introduced Handler
- Further TestGenerator refactor work to use constants - Scope now passed into generateStepsPhp (to support test/hook/suite) - refactored $data.key$ references to use handler for value retrieval
- Incorrect generation fixes.
- Unit tests created - Update to all verification tests
- Updated Generator to use private variable for currentScope, refactored signatures to account for this - verification test update to increase coverage
- Fixed merged verification test
- ActionGroups were not replacing their createDataKey references correctly. - Added new test for above use case - No hooks no longer assign a variable (not necessary), verification test updates
- Fix verification test
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 24, 2022
3.10.2 RC merging master back to develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
$data.field$syntax$$data.field$$and$data.field$references now do the same thing; can be deprecated.Contribution checklist