Skip to content

MQE-1068: Require Issue ID for Skipped Test #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 10, 2018
Merged

MQE-1068: Require Issue ID for Skipped Test #167

merged 13 commits into from
Jul 10, 2018

Conversation

aljcalandra
Copy link
Contributor

Skip tags will now be required instead of using <group value="skip"/>

Tests still using <group value="skip"/> will cause deprecation warning on generation.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

aljcalandra and others added 12 commits June 22, 2018 11:23
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
f7cb05e 
- Added Schema information for Skip and issueId
- Added tests around skip code
- Added deprecation warning for group skip
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
b4bdf77 
- Moved deprecation warning
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
7a4fa48 
- Made TODO messages more informative
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
eca4c88 
- Added missing {} for foreach
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
9737bd8 
- Removed IssueId comment generator
- Updated Tests
- Added merge test
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
e7833c7 
- Changed to log for warning
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
2cfa59a 
- Removed verbose requirement for deprecation warnign flag
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
5f92b6a 
- Added Skip text for issue Ids
- Update and added test
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
cb5f51b 
- Fixed Tests
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
e7ab0b6 
- Added reason and description to skip tag
@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
8353881 
- Removing Skip and description
@aljcalandra
Merge branch 'develop' into MQE-1068
64dd3b3
@coveralls
Copy link

coveralls commented Jul 10, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 56.227% when pulling cb17300 on MQE-1068 into bf22ecb on develop.

@aljcalandra
MQE-1068: Require Issue ID for Skipped Test
cb17300 
- Correcting static check issue
@aljcalandra aljcalandra merged commit 9bafd56 into develop Jul 10, 2018
@aljcalandra aljcalandra deleted the MQE-1068 branch July 10, 2018 19:25
magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 28, 2022
@glo00108 @KevinBKozan
MQE-3121 MFTF config parallel to support input test names from a file (…
8c85258 
…#167)

* MQE-3121 MFTF config parallel to support input test names from a file

* fix static checks and ac.

* updated doc

* added example

* Update mftf.md

Co-authored-by: Kevin Kozan <[email protected]>
Co-authored-by: Kevin Kozan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljcalandra @coveralls