Skip to content

run:<x> command always returns exit code of 0 #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
powli opened this issue Apr 24, 2019 · 1 comment
Closed

run:<x> command always returns exit code of 0 #337

powli opened this issue Apr 24, 2019 · 1 comment

Comments

@powli
Copy link
Contributor

powli commented Apr 24, 2019

Preconditions

  1. Any supported Magento version
  2. Any MFTF version

Steps to reproduce

Run the vendor/bin/mftf run:test, vendor/bin/mftf run:group or vendor/bin/mftf run:failed command with failing tests

Expected result

The command should return a non-zero exit code as errors occured

Actual result

The command returns an exit code of zero

This is especially relevant in a CI environment where many job setups depend on the exit code of the run commands. In this case, we had a job showing as green even though the MFTF tests in the job failed.
This also blocks command chaining in the CLI, e.g. vendor/bin/mftf run:test FailingTest >> test.log && echo "Test success" will always print out "Test success".

@powli
Copy link
Contributor Author

powli commented Apr 25, 2019

Resolved with #338

@powli powli closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant