Skip to content

EQPS-477: SVC Enhancements #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2020
Merged

EQPS-477: SVC Enhancements #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef3ae79
EQPS-477: Dynamically set the correct path for autoload.php based on …
roribio Feb 27, 2020
7dedc0f
EQPS-477: Make zend-stdlib a required dependency
roribio Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bin/svc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@
* See COPYING.txt for license details.
*/

require __DIR__ . '/../vendor/autoload.php';
foreach ([__DIR__ . '/../../../autoload.php', __DIR__ . '/../vendor/autoload.php'] as $file) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do something if no autoload.php file was found?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's critical but we can throw an exception and suggest the user run the composer command. I don't see a scenario where the autoload.php file would be anywhere else.

if (file_exists($file)) {
require $file;
break;
}
}

use Symfony\Component\Console\Application;
use Magento\SemanticVersionChecker\Console\Command\CompareSourceCommand;
Expand Down
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
"bin": ["bin/svc"],
"require": {
"php": "~7.1.3||~7.2.0||~7.3.0",
"tomzx/php-semver-checker": "^0.13.0",
"symfony/console": "~4.4.0",
"phpstan/phpdoc-parser": "^0.3.5",
"wikimedia/less.php": "~1.8.0"
"symfony/console": "~4.4.0",
"tomzx/php-semver-checker": "^0.13.0",
"wikimedia/less.php": "~1.8.0",
"zendframework/zend-stdlib": "^3.2.1"
},
"require-dev": {
"phpunit/phpunit": "^6.5.0",
"zendframework/zend-stdlib": "^3.2.1",
"squizlabs/php_codesniffer": "^3.5"
},
"autoload": {
Expand Down
Loading