Skip to content

MAGECLOUD-5101: Forward-port 1.0 branch #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
"ext-json": "*",
"composer/composer": "^1.0",
"composer/semver": "^1.0",
"illuminate/config": "^5.6",
"illuminate/filesystem": "^5.6",
"symfony/config": "^3.4||^4.0",
"symfony/console": "^2.3||^4.0",
"symfony/dependency-injection": "^3.1||^4.0",
"illuminate/config": "^5.5",
"illuminate/filesystem": "^5.5",
"symfony/config": "^4.4",
"symfony/console": "^2.8||^4.0",
"symfony/dependency-injection": "^3.3||^4.3",
"symfony/yaml": "^3.3||^4.0"
},
"require-dev": {
Expand Down
7 changes: 4 additions & 3 deletions dist/bin/magento-docker
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ USAGE="Magento Cloud Docker
stop stop containers
start start containers
restart restart containers
ece-build build application
ece-deploy deploy application
ece-redeploy re-build and re-deploy application
ece-build run build hooks
ece-deploy run deploy hooks
ece-post-deploy run post-deploy hooks
ece-redeploy run build, deploy, and post-deploy hooks

\033[33mOptions:\033[0m
-h show this help text\n"
Expand Down
7 changes: 7 additions & 0 deletions images/php/7.1-cli/docker-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,17 @@ fi
# Ensure our Magento directory exists
mkdir -p $MAGENTO_ROOT

CRON_LOG=/var/log/cron.log

if [ ! -z "${CRONTAB}" ]; then
echo "${CRONTAB}" > /etc/cron.d/magento
fi

# Get rsyslog running for cron output
touch $CRON_LOG
echo "cron.* $CRON_LOG" > /etc/rsyslog.d/cron.conf
service rsyslog start

# Configure Sendmail if required
if [ "$ENABLE_SENDMAIL" == "true" ]; then
/etc/init.d/sendmail start
Expand Down
7 changes: 7 additions & 0 deletions images/php/7.2-cli/docker-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,17 @@ fi
# Ensure our Magento directory exists
mkdir -p $MAGENTO_ROOT

CRON_LOG=/var/log/cron.log

if [ ! -z "${CRONTAB}" ]; then
echo "${CRONTAB}" > /etc/cron.d/magento
fi

# Get rsyslog running for cron output
touch $CRON_LOG
echo "cron.* $CRON_LOG" > /etc/rsyslog.d/cron.conf
service rsyslog start

# Configure Sendmail if required
if [ "$ENABLE_SENDMAIL" == "true" ]; then
/etc/init.d/sendmail start
Expand Down
7 changes: 7 additions & 0 deletions images/php/7.3-cli/docker-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,17 @@ fi
# Ensure our Magento directory exists
mkdir -p $MAGENTO_ROOT

CRON_LOG=/var/log/cron.log

if [ ! -z "${CRONTAB}" ]; then
echo "${CRONTAB}" > /etc/cron.d/magento
fi

# Get rsyslog running for cron output
touch $CRON_LOG
echo "cron.* $CRON_LOG" > /etc/rsyslog.d/cron.conf
service rsyslog start

# Configure Sendmail if required
if [ "$ENABLE_SENDMAIL" == "true" ]; then
/etc/init.d/sendmail start
Expand Down
7 changes: 7 additions & 0 deletions images/php/cli/docker-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,17 @@ fi
# Ensure our Magento directory exists
mkdir -p $MAGENTO_ROOT

CRON_LOG=/var/log/cron.log

if [ ! -z "${CRONTAB}" ]; then
echo "${CRONTAB}" > /etc/cron.d/magento
fi

# Get rsyslog running for cron output
touch $CRON_LOG
echo "cron.* $CRON_LOG" > /etc/rsyslog.d/cron.conf
service rsyslog start

# Configure Sendmail if required
if [ "$ENABLE_SENDMAIL" == "true" ]; then
/etc/init.d/sendmail start
Expand Down
1 change: 0 additions & 1 deletion src/Compose/BuilderInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ interface BuilderInterface
public const VOLUME_MAGENTO_MEDIA = 'magento-media';
public const VOLUME_MAGENTO_DB = 'magento-db';
public const VOLUME_MAGENTO_DEV = 'magento-dev';
public const VOLUME_DOCKER_TMP = 'docker-tmp';
public const VOLUME_DOCKER_MNT = 'docker-mnt';

/**
Expand Down
8 changes: 0 additions & 8 deletions src/Compose/ProductionBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,6 @@ public function build(Repository $config): Manager
}

if ($this->getMountVolumes($config)) {
$volumes[self::VOLUME_DOCKER_TMP] = [
'driver_opts' => [
'type' => 'none',
'device' => $rootPath . '/.docker/tmp',
'o' => 'bind'
]
];
$volumes[self::VOLUME_DOCKER_MNT] = [
'driver_opts' => [
'type' => 'none',
Expand Down Expand Up @@ -532,7 +525,6 @@ private function getMountVolumes(Repository $config): array

return [
self::VOLUME_DOCKER_MNT . ':/mnt',
self::VOLUME_DOCKER_TMP . ':/tmp'
];
}
}