Skip to content

MAGECLOUD-4979: Cleanup Composer Dependencies #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2020
Merged

MAGECLOUD-4979: Cleanup Composer Dependencies #121

merged 4 commits into from
Jan 17, 2020

Conversation

bbatsche
Copy link
Member

Description

  • Lower the minimum version of a couple of packages to support M 2.1 & PHP 7.1.
  • Narrowed the set of installable versions where no conflict should exist with Magento or other modules
  • Made the version constraints consistent across Magento Cloud packages

Fixed Issues (if relevant)

MAGECLOUD-4979

Manual testing scenarios

None, dependencies should be installable.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

aepod
aepod previously approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@aepod aepod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, should not cause any issues.

billygilbert
billygilbert previously approved these changes Jan 14, 2020
View reviewed changes
BaDos
BaDos previously approved these changes Jan 14, 2020
View reviewed changes
@bbatsche bbatsche dismissed stale reviews from BaDos, billygilbert, and aepod via 5f0ec1c January 15, 2020 17:29
@andriyShevtsov
Copy link
Contributor

QA approved

@mveeramneni mveeramneni added Progress: accept PR/issue status and removed onhold labels Jan 17, 2020
@billygilbert billygilbert merged commit 1e73c8e into 1.0 Jan 17, 2020
@billygilbert billygilbert deleted the MAGECLOUD-4979 branch January 17, 2020 16:24
magento-devops-reposync-svc pushed a commit that referenced this pull request Mar 26, 2024
@andriyShevtsov
Merge pull request #121 from magento-commerce/MCLOUD-11659
857a9ec 
MCLOUD-11659: Added PHP 8.3 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billygilbert billygilbert billygilbert approved these changes

@mveeramneni mveeramneni mveeramneni approved these changes

@aepod aepod aepod left review comments

@BaDos BaDos BaDos left review comments

Assignees

@bbatsche bbatsche

Labels
Progress: accept PR/issue status Release: 1.0.0 Magento-Cloud-Docker Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bbatsche @andriyShevtsov @aepod @BaDos @billygilbert @mveeramneni @YPyltiai