Developer mode workflow

[drpayyne]

Preconditions

1. Use Magento Cloud Docker in developer mode

Steps to reproduce

1. Follow steps in https://devdocs.magento.com/cloud/docker/docker-mode-developer.html to use cloud-docker in dev mode

Expected result

1. Developers shouldn't have to run docker-compose run --rm deploy magento-command deploy:mode:set developer every time after cloud-deploy when docker-compose file was generated for developer mode. This sets the flag MAGE_MODE=developer. This should be used in cloud-deploy scenario to set the mode as developer instead of production, if present. I don't understand why we can't use that flag to set the deploy mode. Or another flag in probably .docker/config.env, in case the MAGE_MODE flag is meant only for the docker containers.

Actual result

1. We have to set the deploy:mode to developer after every run of cloud deploy even if build:compose was run with developer flag since cloud-deploy always sets mode to production no matter the environment mode. During development, this seems unnecessary.

[drpayyne]

Yes, this isn't as simple as fixing the scenario to use the MAGE_MODE flag since this has implications on processes like setup:di:compile and setup:static-content:deploy.

[shiftedreality]

We probably can add a new command/flag to https://github.com/magento/magento-cloud-docker/blob/develop/dist/bin/magento-docker and switch this after successful deployment.

Volunteer needed

[shiftedreality]

Internal issue: https://jira.corp.magento.com/browse/MCLOUD-7991

[asannikov]

you can modify the file .magento.app.yaml

deploy: |
        php ./vendor/bin/ece-tools run scenario/deploy.xml

just replace scenario/deploy.xml with your custom scenario.

it has block:

<step name="pre-deploy" type="Magento\MagentoCloud\Step\Deploy\PreDeploy" priority="200">
        <arguments>
            <argument name="logger" xsi:type="object">Psr\Log\LoggerInterface</argument>
            <argument name="steps" xsi:type="array">
                <item name="restore-patch-log" xsi:type="object" priority="25">Magento\MagentoCloud\Step\Deploy\PreDeploy\RestorePatchLog</item>
                <item name="check-state" xsi:type="object" priority="50">Magento\MagentoCloud\Step\Deploy\PreDeploy\CheckState</item>
                <item name="cache" xsi:type="object" priority="100">Magento\MagentoCloud\Step\Deploy\PreDeploy\ConfigUpdate\Cache</item>
                <item name="clean-static-content" xsi:type="object" priority="200">Magento\MagentoCloud\Step\Deploy\PreDeploy\CleanStaticContent</item>
                <item name="clean-view-preprocessed" xsi:type="object" priority="300">Magento\MagentoCloud\Step\Deploy\PreDeploy\CleanViewPreprocessed</item>
                <item name="clean-redis-cache" xsi:type="object" priority="400">Magento\MagentoCloud\Step\Deploy\PreDeploy\CleanRedisCache</item>
                <item name="clean-file-cache" xsi:type="object" priority="500">Magento\MagentoCloud\Step\Deploy\PreDeploy\CleanFileCache</item>
                <item name="restore-writable-dirs" xsi:type="object" priority="600">Magento\MagentoCloud\Step\Deploy\PreDeploy\RestoreWritableDirectories</item>
                <item name="set-production-mode" xsi:type="object" priority="700">Magento\MagentoCloud\Step\SetProductionMode</item>
            </argument>
        </arguments>
    </step>

remove set-production-mode tag and it will work