Skip to content

Propose changes to field types in Add Products to cart mutations #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

Propose changes to field types in Add Products to cart mutations #412

merged 1 commit into from
Jul 30, 2020

Conversation

prabhuram93
Copy link

@prabhuram93 prabhuram93 commented Jul 30, 2020 •
edited
Loading

Problem

  1. Changes need to be propagated from these 2 PRs Propose renaming id_v2 to something more permanent, and change type #396, Add document with suggestions for ID fields #395

Solution

  1. Update id field types from String! to ID!
  2. If a new mutation is expected to use encoded ids, then name it uid

Requested Reviewers

@paliarush @DrewML

@paliarush paliarush merged commit 0cc6ac2 into magento:master Jul 30, 2020
prabhuram93 pushed a commit to rogyar/magento2 that referenced this pull request Aug 4, 2020
- Removed dependency between QuoteGQL and WishlistGQL (magento/archit…
330e763 
…ecture#413)

- fixed uid field types (magento/architecture#412)
- fixed api functional tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrewML DrewML DrewML approved these changes

@paliarush paliarush paliarush approved these changes

Assignees
No one assigned
Labels
GraphQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prabhuram93 @DrewML @paliarush