-
Notifications
You must be signed in to change notification settings - Fork 12
Add unicode datetime attribute #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ikonst are we ok with running |
Let's black it in a separate PR first? Totally supportive of black btw. |
f344fd6
to
0af89ea
Compare
@ikonst done! I will ship another PR where this gets |
@ikonst added 3.9 in the test matrix. I signed the CLA but it is not passing. Let me know if there's anything else I can do. |
@ikonst I will break this PR into 3 separate PRs
|
5fd112d
to
7277aa3
Compare
💨 |
7277aa3
to
e5bf90e
Compare
@ikonst this should be ready for release 0.3.1 |
Co-authored-by: Ilya Konstantinov <[email protected]>
🚢 |
Thanks for bearing with me! :) |
This PR adds the
UnicodeDatetimeAttribute
attribute type for storing datetimes as 8601 ISO strings with offset.Usage
The storage representation of this format will look something like:
The attribute by default will add an offset to UTC if not present and make it timezone aware. It also as options for normalizing the date to UTC (for caching purposes) and adds support for custom formatting.